Skip to content

[5.2] Fix Dart Sass deprecations#44129

Merged
pe7er merged 5 commits intojoomla:5.2-devfrom
C-Lodder:sass-deprecations
Oct 26, 2024
Merged

[5.2] Fix Dart Sass deprecations#44129
pe7er merged 5 commits intojoomla:5.2-devfrom
C-Lodder:sass-deprecations

Conversation

@C-Lodder
Copy link
Member

Summary of Changes

lighten() and darken() are global functions in Dart Sass, that were deprecated as of v1.79.0.
This PR replaces them with color.adjust() inside Joomla's SCSS

Note: Bootstrap's own SCSS still uses these functions, and may or may not fix said deprecations in v5, due to the fact they still support node-sass.

Testing Instructions

Code review

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.2-dev labels Sep 24, 2024
@Quy
Copy link
Contributor

Quy commented Sep 26, 2024

I have tested this item ✅ successfully on e22174c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44129.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on e22174c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44129.

@alikon
Copy link
Contributor

alikon commented Sep 28, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44129.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 28, 2024
@pe7er pe7er self-assigned this Oct 26, 2024
@pe7er pe7er enabled auto-merge (squash) October 26, 2024 15:10
@pe7er pe7er merged commit 30984e7 into joomla:5.2-dev Oct 26, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 26, 2024
@Quy Quy added this to the Joomla! 5.2.1 milestone Oct 26, 2024
@pe7er
Copy link
Contributor

pe7er commented Oct 26, 2024

Thanks @C-Lodder !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants