[4.4] Check pagination parameters from request, another try

[Fedik]

Summary of Changes

Existing approach still have a problem, it is always forcing the parameters defined in $defaultUrlParams, and make it impossible to remove.

I suggest a different approach, take the allowed parameters from the router, and filtering them before adding. Also this now happen in the pagination constructor, which allows for developers to unset unneeded params.

Testing Instructions

Code review. Test with your component.

Or, add following code, somewhere here

joomla-cms/templates/cassiopeia/index.php

Line 202 in 67cd90e

<main>

<?php
$pg = new \Joomla\CMS\Pagination\Pagination(100, 0, 20);
$pg->setAdditionalUrlParam('tmpl', null);
echo $pg->getPaginationLinks();
?>

Then open any page with ?tmpl=index in URL, and check pagination links.

Actual result BEFORE applying this Pull Request

Somehow works.

Pagination links contain ?tmpl=index .

Expected result AFTER applying this Pull Request

Works but better.

Pagination links without ?tmpl=index .

Link to documentations

Please select:

• Documentation link for docs.joomla.org:
• No documentation changes for docs.joomla.org needed
• Pull Request link for manual.joomla.org:
• No documentation changes for manual.joomla.org needed

[SniperSister]

This PR re-introduces the issue that was fixed in the security release.

[Fedik]

I updated the PR, it now takes only allowed parameters.

[PhocaCz]

Testing now, after getting more information, it seems to be working fine for me. I will do more tests to confirm this PR. Thank you.

[PhocaCz]

I have tested this item ✅ successfully on 097ef2e

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44023.}

[Fedik]

@n3t your test is unrelated to current PR.
For fixing start=0 there need a separated fix. Please test #44069

[n3t]

I have tested this item ✅ successfully on 399ab15

In combination with patch #44069 this works as expected.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44023.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44023.}

[MacJoom]

Thank you!