[4.x] Fix default language value for taxonomy rows#43990
Merged
laoneo merged 4 commits intojoomla:4.4-devfrom Aug 30, 2024
Merged
[4.x] Fix default language value for taxonomy rows#43990laoneo merged 4 commits intojoomla:4.4-devfrom
laoneo merged 4 commits intojoomla:4.4-devfrom
Conversation
|
I have tested this item ✅ successfully on c61e65b Without Patch:With Patch:This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43990. |
Contributor
Author
|
@fgsw thanks for testing, that's very much appreciated! I have pushed another commit that will also fix the language in the first taxonomy levels that you marked red in your screenshot. Could you please re-rest? THANK YOU! |
|
I have tested this item ✅ successfully on 0120dfd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43990. |
|
@fgsw Thank you for screenshots for my better understanding :-) This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43990. |
|
I have tested this item ✅ successfully on 0120dfd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43990. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43990. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary of Changes
So far com_finder taxonomy rows had an empty string as default parameter for the language column. Taxonomy rows with that empty string became unselectable one the multilanguage feature was enabled, as the language filter only filtered for the current language and the * character, see:
https://github.com/joomla/joomla-cms/blob/4.4-dev/administrator/components/com_finder/src/Service/HTML/Filter.php#L306
Testing Instructions
Actual result BEFORE applying this Pull Request
Rows with empty string.
Expected result AFTER applying this Pull Request
Rows with empty strings are now using * as value
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed