Skip to content

Comments

[4.x] Fix default language value for taxonomy rows#43990

Merged
laoneo merged 4 commits intojoomla:4.4-devfrom
SniperSister:4.4-finder-taxonomy-language
Aug 30, 2024
Merged

[4.x] Fix default language value for taxonomy rows#43990
laoneo merged 4 commits intojoomla:4.4-devfrom
SniperSister:4.4-finder-taxonomy-language

Conversation

@SniperSister
Copy link
Contributor

@SniperSister SniperSister commented Aug 27, 2024

Summary of Changes

So far com_finder taxonomy rows had an empty string as default parameter for the language column. Taxonomy rows with that empty string became unselectable one the multilanguage feature was enabled, as the language filter only filtered for the current language and the * character, see:
https://github.com/joomla/joomla-cms/blob/4.4-dev/administrator/components/com_finder/src/Service/HTML/Filter.php#L306

Testing Instructions

  • Run the finder indexer, view the #__finder_taxonomy table and check the taxonomy column values.
  • Apply the patch.
  • Reindex
  • Check the DB table again

Actual result BEFORE applying this Pull Request

Rows with empty string.

Expected result AFTER applying this Pull Request

Rows with empty strings are now using * as value

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@ghost
Copy link

ghost commented Aug 28, 2024

I have tested this item ✅ successfully on c61e65b

Without Patch:

patch-no

With Patch:

patch


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43990.

@SniperSister
Copy link
Contributor Author

@fgsw thanks for testing, that's very much appreciated! I have pushed another commit that will also fix the language in the first taxonomy levels that you marked red in your screenshot. Could you please re-rest? THANK YOU!

@ghost
Copy link

ghost commented Aug 28, 2024

I have tested this item ✅ successfully on 0120dfd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43990.

@ChristineWk
Copy link

@fgsw Thank you for screenshots for my better understanding :-)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43990.

@ChristineWk
Copy link

I have tested this item ✅ successfully on 0120dfd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43990.

@Quy
Copy link
Contributor

Quy commented Aug 29, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43990.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 29, 2024
@laoneo laoneo added this to the Joomla! 4.4.9! milestone Aug 30, 2024
@laoneo laoneo enabled auto-merge (squash) August 30, 2024 05:41
@laoneo laoneo merged commit db5d739 into joomla:4.4-dev Aug 30, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants