Change 'option' filter in Pagination.php from WORD to CMD#43976
Closed
jurihahn wants to merge 1 commit intojoomla:5.3-devfrom
Closed
Change 'option' filter in Pagination.php from WORD to CMD#43976jurihahn wants to merge 1 commit intojoomla:5.3-devfrom
jurihahn wants to merge 1 commit intojoomla:5.3-devfrom
Conversation
Changed the default 'option' parameter value from 'WORD' to 'CMD'.
Member
|
Please make the PR to 4.4-dev branch, because it is a bug. |
2 tasks
Member
|
Thank you for the reaport. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the default 'option' parameter value from 'WORD' to 'CMD'.
Summary of Changes
This modification ensures that components with numbers in their names (e.g., com_example123) are correctly recognized and processed by the Joomla pagination system. Previously, the WORD filter would strip out numeric characters, causing issues when routing to components with numeric names.
Testing Instructions
Create a component with numbers in its name (e.g., com_example123).
Implement pagination in the component.
Navigate through the paginated views of the component.
Verify the URL includes the full name of the component, including numbers, when you move through pages.
Confirm the component functions correctly and that the pagination operates as expected without errors.
Actual result BEFORE applying this Pull Request
URLs for paginated pages would strip numbers from the option parameter, leading to incorrect routing.
Components with numbers in their names could not be correctly identified by the system, causing potential 404 errors.
Expected result AFTER applying this Pull Request
URLs for paginated pages will correctly retain numbers in the option parameter.
Components with numeric characters in their names will be properly recognized and routed, ensuring they function as expected without issues.
Link to documentations
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed