Skip to content

Change 'option' filter in Pagination.php from WORD to CMD#43976

Closed
jurihahn wants to merge 1 commit intojoomla:5.3-devfrom
jurihahn:5.3-dev
Closed

Change 'option' filter in Pagination.php from WORD to CMD#43976
jurihahn wants to merge 1 commit intojoomla:5.3-devfrom
jurihahn:5.3-dev

Conversation

@jurihahn
Copy link
Contributor

Changed the default 'option' parameter value from 'WORD' to 'CMD'.

Summary of Changes

This modification ensures that components with numbers in their names (e.g., com_example123) are correctly recognized and processed by the Joomla pagination system. Previously, the WORD filter would strip out numeric characters, causing issues when routing to components with numeric names.

Testing Instructions

Create a component with numbers in its name (e.g., com_example123).
Implement pagination in the component.
Navigate through the paginated views of the component.
Verify the URL includes the full name of the component, including numbers, when you move through pages.
Confirm the component functions correctly and that the pagination operates as expected without errors.

Actual result BEFORE applying this Pull Request

URLs for paginated pages would strip numbers from the option parameter, leading to incorrect routing.
Components with numbers in their names could not be correctly identified by the system, causing potential 404 errors.

Expected result AFTER applying this Pull Request

URLs for paginated pages will correctly retain numbers in the option parameter.
Components with numeric characters in their names will be properly recognized and routed, ensuring they function as expected without issues.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

Changed the default 'option' parameter value from 'WORD' to 'CMD'.
@Fedik
Copy link
Member

Fedik commented Aug 24, 2024

Please make the PR to 4.4-dev branch, because it is a bug.
Thank you.

@Fedik
Copy link
Member

Fedik commented Aug 25, 2024

Thank you for the reaport.
The complete fix is there #43983, please test.

@Fedik Fedik closed this Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants