-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[6.0] Numbers custom fields plugin #43974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@brianteeman Thanks for reviewing and fixing my mistakes. |
|
So the wall i'm hitting now is that i can't figure out how the display of the custom field in an "article edit view" is set or adjusted. Looking at for instance the integer custom field it sort of automagically seems to work. Because i can't seem to find a reference anywhere in the plugin folder itself. Could someone point me in the right direction here? |
There is still some work to be done regarding the databases and the installation, see e.g.: A nice example of another plugin can be found here: |
|
This pull request has been automatically rebased to 5.3-dev. |
Co-authored-by: Brian Teeman <[email protected]>
Co-authored-by: Brian Teeman <[email protected]>
|
I have tested this item 🔴 unsuccessfully on 3d8f2bc For more information - On discover number field plugin is available and installable. But after onstallation, in standard joomla form the number field is not available. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43974. |
|
Sorry, wrong button. |
|
@exlemor Have you also tested updating from 6.0.0-alpha3? Then you would have noticed that the field will not be added on update due to the wrong update SQL script name. For PRs which add new update SQL scripts updating should always be part of the test. @TLWebdesign Maybe you should update the testing instructions accordingly. |
|
Filenames "6.0.0-2024-08-24.sql" are still wrong. Please rename to "6.0.0-2025-08-17.sql". Mind also the year! |
sorry in the rush to get going here i didn't wait long enough for my laptop to commit the renaming. but i see it is done now. Thanks for your help |
|
I will set RTC as it had 2 tests. @Bodge-IT @softforge When this and the other one with the other field gets merged before beta 1, then we (or you) have to test if updating still works on MySQL and PostgreSQL. I will try to find time for that tomorrow morning, at least for the PostgreSQL part. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43974. |
|
I will solve the conflicts in the base.sql now. |
|
Done. |
|
Thanks @TLWebdesign, well done. Thanks for all the tests |
I'm trying to create a new custom fields plugin for the standard Joomla Form Field Number. We have it for Integer and i'd like to have the same for the number field. That way w'll also gain ability to use floats.
Summary of Changes
Extra plugin added for the numbers standard form field type. With added currency options for display. Making it very useful for display of menu's for restaurants or anything else where a currency or a number is needed to be displayed.
Testing Instructions
You can discover the plugin and then use it in custom fields. It's called numbers.
Create a custom field of type numbers and check weather the options available do what they supposed to be doing. especially related to the number formatting.
Actual result BEFORE applying this Pull Request
No numbers custom field available.
Expected result AFTER applying this Pull Request
Numbers custom field available and working.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed