Skip to content

Conversation

@TLWebdesign
Copy link
Contributor

@TLWebdesign TLWebdesign commented Aug 24, 2024

I'm trying to create a new custom fields plugin for the standard Joomla Form Field Number. We have it for Integer and i'd like to have the same for the number field. That way w'll also gain ability to use floats.

Summary of Changes

Extra plugin added for the numbers standard form field type. With added currency options for display. Making it very useful for display of menu's for restaurants or anything else where a currency or a number is needed to be displayed.

Testing Instructions

You can discover the plugin and then use it in custom fields. It's called numbers.
Create a custom field of type numbers and check weather the options available do what they supposed to be doing. especially related to the number formatting.

Actual result BEFORE applying this Pull Request

No numbers custom field available.

Expected result AFTER applying this Pull Request

Numbers custom field available and working.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.2-dev labels Aug 24, 2024
@TLWebdesign
Copy link
Contributor Author

@brianteeman Thanks for reviewing and fixing my mistakes.

@Fedik Fedik added the Feature label Aug 25, 2024
@TLWebdesign TLWebdesign marked this pull request as draft August 25, 2024 18:38
@TLWebdesign
Copy link
Contributor Author

So the wall i'm hitting now is that i can't figure out how the display of the custom field in an "article edit view" is set or adjusted. Looking at for instance the integer custom field it sort of automagically seems to work. Because i can't seem to find a reference anywhere in the plugin folder itself.

Could someone point me in the right direction here?

@sandewt
Copy link
Contributor

sandewt commented Aug 27, 2024

I'm not there yet and i need help!

There is still some work to be done regarding the databases and the installation, see e.g.:

https://github.com/TLWebdesign/joomla-cms/blob/f9dec464683f19d5efe9699ee8745d703cea7250/installation/sql/mysql/base.sql#L296

A nice example of another plugin can be found here:
https://github.com/joomla/joomla-cms/pull/42777/files

@HLeithner HLeithner changed the base branch from 5.2-dev to 5.3-dev September 2, 2024 08:50
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.3-dev.

@Hackwar Hackwar removed the PR-5.2-dev label Sep 3, 2024
@suvarnakale
Copy link

I have tested this item 🔴 unsuccessfully on 3d8f2bc

I have tested this item and it is not working as expected.

For more information - On discover number field plugin is available and installable. But after onstallation, in standard joomla form the number field is not available.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43974.

@richard67
Copy link
Member

Sorry, wrong button.

@richard67
Copy link
Member

@exlemor Have you also tested updating from 6.0.0-alpha3? Then you would have noticed that the field will not be added on update due to the wrong update SQL script name.

For PRs which add new update SQL scripts updating should always be part of the test.

@TLWebdesign Maybe you should update the testing instructions accordingly.

@richard67
Copy link
Member

Filenames "6.0.0-2024-08-24.sql" are still wrong. Please rename to "6.0.0-2025-08-17.sql". Mind also the year!

@TLWebdesign
Copy link
Contributor Author

Filenames "6.0.0-2024-08-24.sql" are still wrong. Please rename to "6.0.0-2025-08-17.sql". Mind also the year!

sorry in the rush to get going here i didn't wait long enough for my laptop to commit the renaming. but i see it is done now. Thanks for your help

@richard67
Copy link
Member

I will set RTC as it had 2 tests.

@Bodge-IT @softforge When this and the other one with the other field gets merged before beta 1, then we (or you) have to test if updating still works on MySQL and PostgreSQL. I will try to find time for that tomorrow morning, at least for the PostgreSQL part.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43974.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 16, 2025
@richard67 richard67 removed the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Aug 16, 2025
@richard67
Copy link
Member

I will solve the conflicts in the base.sql now.

@richard67
Copy link
Member

Done.

@Bodge-IT Bodge-IT merged commit e7534e0 into joomla:6.0-dev Aug 16, 2025
30 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 16, 2025
@Bodge-IT
Copy link
Contributor

Thanks @TLWebdesign, well done. Thanks for all the tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.