Skip to content

[4.4] Pagination fixes part 2#43967

Merged
MacJoom merged 3 commits intojoomla:4.4-devfrom
SniperSister:fix/pagination-fixes-v2
Aug 23, 2024
Merged

[4.4] Pagination fixes part 2#43967
MacJoom merged 3 commits intojoomla:4.4-devfrom
SniperSister:fix/pagination-fixes-v2

Conversation

@SniperSister
Copy link
Contributor

Summary of Changes

The 4.4.7 and 5.1.3 security release broke the pagination in com_finder and the com_content archive view. Furthermore, parameters were read from $_REQUEST and not from $_GET.

Testing Instructions

Enable the "Show Sort Fields" setting in the Smart Search menu item (under Advanced).
Then use the ordering fields to change the order, in a result set that has several pages and try to change page.

Actual result BEFORE applying this Pull Request

  • The ordering field and direction are vanished.

Expected result AFTER applying this Pull Request

  • The ordering field and direction are kept.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

SniperSister and others added 2 commits August 23, 2024 13:51
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
@richard67
Copy link
Member

@sakiss PR is ready. Could you test? And if successful, go to the PR in the issue tracker here https://issues.joomla.org/tracker/joomla-cms/43967 and mark your test result by using the blue "Test this" button at the top left corner? Thanks in advance.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 6d4b67a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43967.

@hans2103
Copy link
Contributor

I have tested this item ✅ successfully on 6d4b67a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43967.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43967.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 23, 2024
@MacJoom MacJoom added this to the Joomla! 4.4.8 milestone Aug 23, 2024
@MacJoom MacJoom merged commit 936f5da into joomla:4.4-dev Aug 23, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants