[4.4] Pagination fixes part 2#43967
Merged
MacJoom merged 3 commits intojoomla:4.4-devfrom Aug 23, 2024
Merged
Conversation
4 tasks
richard67
reviewed
Aug 23, 2024
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Member
|
@sakiss PR is ready. Could you test? And if successful, go to the PR in the issue tracker here https://issues.joomla.org/tracker/joomla-cms/43967 and mark your test result by using the blue "Test this" button at the top left corner? Thanks in advance. |
Member
|
I have tested this item ✅ successfully on 6d4b67a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43967. |
brianteeman
reviewed
Aug 23, 2024
Contributor
|
I have tested this item ✅ successfully on 6d4b67a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43967. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43967. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The 4.4.7 and 5.1.3 security release broke the pagination in com_finder and the com_content archive view. Furthermore, parameters were read from $_REQUEST and not from $_GET.
Testing Instructions
Enable the "Show Sort Fields" setting in the Smart Search menu item (under Advanced).
Then use the ordering fields to change the order, in a result set that has several pages and try to change page.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed