[4.4] Fix default parameters for pagination

[Fedik]

Pull Request for Issue # .

Summary of Changes

Added a few missing but required parameters.
And replaced use of deprecated app->input to modern.

Testing Instructions

code review

Link to documentations

Please select:

• Documentation link for docs.joomla.org:
• No documentation changes for docs.joomla.org needed
• Pull Request link for manual.joomla.org:
• No documentation changes for manual.joomla.org needed

ping @SniperSister

[SniperSister]

I have tested this item ✅ successfully on 43605d4

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43954.}

[Hackwar]

You are filtering by CMD in most cases. Is that correct? And for id we are filtering by INT, but our id is actually a string with the alias at the end. Yes, the core does handle that, but not necessarily third party extensions. Also, should we have to add catid here as well?

[SniperSister]

Regarding the ID parameter:
If you want to change the INT into a STRING or CMD, make sure to apply the same change to the component cache key:

joomla-cms/libraries/src/Cache/Cache.php

Line 690 in 8a868a3

'id' => 'INT',

[SniperSister]

Same applies to the other suggested changes

[Hackwar]

Do we really need to have the cache key parameter be CMD as well? I currently don't see the necessity for that...

[SniperSister]

Do we really need to have the cache key parameter be CMD as well? I currently don't see the necessity for that...

Yes we do, otherwise we re-introduce the issue again.

[Hackwar]

But having it be INT is far more restrictive than CMD and we only need the CMD for the router...

[Fedik]

If you want to change the INT into a STRING or CMD,

Should I? I am fine with integer.
hm, but is there still use cases like &id=1:foobar-alias?

You are filtering by CMD in most cases. Is that correct? And for id we are filtering by INT

I did not change filter for the ID.
I only change where was "WORD" filter, I checked the CMS code, and in most cases there is "CMD"
IDK if the ID realy need in pagination. But I can change to anything.