Skip to content

Comments

Feature/4 4 docblock typo#43946

Merged
laoneo merged 2 commits intojoomla:4.4-devfrom
hans2103:feature/4-4-docblock-typo
Aug 30, 2024
Merged

Feature/4 4 docblock typo#43946
laoneo merged 2 commits intojoomla:4.4-devfrom
hans2103:feature/4-4-docblock-typo

Conversation

@hans2103
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

This PR without any issue will fix some typos in DocBlock
When DocBlock states that some code is deprecated and comes with an alternative it would be nice if the alternative is free from typos.

Testing Instructions

open mentioned files
look for the docblock of the changed lines
apply pr
and see changes in docblock.

this PR will not change any functionality of Joomla.
Just fixing typo in DocBlock

Actual result BEFORE applying this Pull Request

     * @deprecated  4.0 will be removed in 6.0
     *              Use the configuration object within the application.
     *              Example: Factory::getApplication->getConfig();
     */

Expected result AFTER applying this Pull Request

     * @deprecated  4.0 will be removed in 6.0
     *              Use the configuration object within the application.
     *              Example: Factory::getApplication()->getConfig();
     */

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 1fffadc

Not typos - they are errors


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43946.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 1fffadc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43946.

@richard67 richard67 changed the title Feature/4 4 docblock typo Feature/4 4 docblock typo Aug 18, 2024
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43946.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 18, 2024
@laoneo laoneo merged commit ddca6ac into joomla:4.4-dev Aug 30, 2024
@laoneo
Copy link
Member

laoneo commented Aug 30, 2024

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 30, 2024
@laoneo laoneo added this to the Joomla! 4.4.9! milestone Aug 30, 2024
@hans2103 hans2103 deleted the feature/4-4-docblock-typo branch August 30, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants