Skip to content

[5.2] Update deleted files list in script.php for 5.2.0-beta1#43942

Closed
richard67 wants to merge 2 commits intojoomla:5.2-devfrom
richard67:5.2-dev-deleted-files-2024-08-18
Closed

[5.2] Update deleted files list in script.php for 5.2.0-beta1#43942
richard67 wants to merge 2 commits intojoomla:5.2-devfrom
richard67:5.2-dev-deleted-files-2024-08-18

Conversation

@richard67
Copy link
Member

@richard67 richard67 commented Aug 18, 2024

Pull Request for Issue # .

Summary of Changes

This pull request (PR) updates the list of files to be deleted on update in file administrator/components/com_admin/script.php in the 5.2-dev branch in preparation for the next 5.2.0-beta1 release.

All files added by this PR are deleted due to the update the joomla framework composer dependencies, where developer-only files are not shipped anymore.

Code review, or if you want to do a real test:

Update a 5.2.0-alpha3 to a current 5.2-dev build which contains the changes from the merged PR #43939 to get the actual result, and update a 5.2.0-alpha3 to the patched package created by Drone for this PR to get the expected result.

To create a current 5.2-dev build, open a Linux or WSL shell, change to the base folder of your git clone, checkout the 5.2-dev branch of the CMS repo or update your 5.2-dev branch to that (upstream) and then run:

php ./build/build.php --remote=HEAD --exclude-gzip --exclude-zstd

And here you can find the patched update package or custom update URL created by Drone for this PR: https://artifacts.joomla.org/drone/joomla/joomla-cms/5.2-dev/43942/downloads/78194/Joomla_5.2.0-alpha4-dev+pr.43942-Development-Update_Package.zip

Actual result BEFORE applying this Pull Request

The files added by this PR to file administrator/components/com_admin/script.php are still present after the update.

Expected result AFTER applying this Pull Request

The files added by this PR to file administrator/components/com_admin/script.php have been removed with the update.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

@richard67
Copy link
Member Author

Closing in favour of #43944 , which should be merged up into 5.2-dev.

@richard67 richard67 closed this Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants