-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[6.1] Ensure isMediaFile defaults to all supported formats when mediatypes is not specified #43915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mattelkins-bluefrontier
wants to merge
5
commits into
joomla:6.1-dev
Choose a base branch
from
mattelkins-bluefrontier:media-api-default-formats-fix
base: 6.1-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+9
−2
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6079aa7
Reapplying relevant changes from PR #43640.
mattelkins-bluefrontier 72f667f
Adding array_filter to handle the scenario where mediatypes is an emp…
mattelkins-bluefrontier 1576e22
Reformat for readability.
mattelkins-bluefrontier 2ab5727
Merge branch '5.2-dev' into media-api-default-formats-fix
mattelkins-bluefrontier 5946845
Merge branch '5.3-dev' into media-api-default-formats-fix
mattelkins-bluefrontier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fallback was hardcoded to 0 (images) for backward compatibility. Changing this needs to be done in a major version and after checking that it won’t break the majority of 3rd party extensions. Also it needs a good communication… fwiw I don’t know what exactly it would solve to allow everything by default, good systems are usually restricted by default…