Skip to content

Comments

[5.1] Fix header translation for modal select field#43878

Merged
bembelimen merged 3 commits intojoomla:5.1-devfrom
Fedik:fix-modalselect-title-lang
Aug 10, 2024
Merged

[5.1] Fix header translation for modal select field#43878
bembelimen merged 3 commits intojoomla:5.1-devfrom
Fedik:fix-modalselect-title-lang

Conversation

@Fedik
Copy link
Member

@Fedik Fedik commented Aug 3, 2024

Pull Request for Issue #42918

Summary of Changes

Fix header translation for modal select field

Testing Instructions

Add following field XML, somewhere, example in Custom HTML module.

<field
  type="ModalSelect"
  name="article"
  label="Article"

  select="true"
  titleSelect="JGLOBAL_SELECT_AN_OPTION"
  urlSelect="index.php?option=com_content&amp;view=articles&amp;layout=modal&amp;tmpl=component"
  clear="true"
/>

Then edit the form with it, click "select" button.
Check the dialog heading.

Actual result BEFORE applying this Pull Request

The heading is untranslated language constant.

Expected result AFTER applying this Pull Request

The heading is translated

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

@Quy
Copy link
Contributor

Quy commented Aug 7, 2024

I have tested this item ✅ successfully on 1ddceaf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43878.

1 similar comment
@ghost
Copy link

ghost commented Aug 7, 2024

I have tested this item ✅ successfully on 1ddceaf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43878.

@Quy
Copy link
Contributor

Quy commented Aug 7, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43878.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 7, 2024
@bembelimen bembelimen merged commit eb800de into joomla:5.1-dev Aug 10, 2024
@bembelimen
Copy link
Contributor

Thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 10, 2024
@bembelimen bembelimen added this to the Joomla! 5.1.3 milestone Aug 10, 2024
@Fedik Fedik deleted the fix-modalselect-title-lang branch August 10, 2024 13:32
dgrammatiko pushed a commit to dgrammatiko/joomla-cms that referenced this pull request Aug 11, 2024
dgrammatiko pushed a commit to dgrammatiko/joomla-cms that referenced this pull request Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants