[5.1] Fix header translation for modal select field#43878
Merged
bembelimen merged 3 commits intojoomla:5.1-devfrom Aug 10, 2024
Merged
[5.1] Fix header translation for modal select field#43878bembelimen merged 3 commits intojoomla:5.1-devfrom
bembelimen merged 3 commits intojoomla:5.1-devfrom
Conversation
richard67
approved these changes
Aug 3, 2024
Contributor
|
I have tested this item ✅ successfully on 1ddceaf This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43878. |
1 similar comment
|
I have tested this item ✅ successfully on 1ddceaf This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43878. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43878. |
Contributor
|
Thx |
dgrammatiko
pushed a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Aug 11, 2024
dgrammatiko
pushed a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Aug 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #42918
Summary of Changes
Fix header translation for modal select field
Testing Instructions
Add following field XML, somewhere, example in Custom HTML module.
Then edit the form with it, click "select" button.
Check the dialog heading.
Actual result BEFORE applying this Pull Request
The heading is untranslated language constant.
Expected result AFTER applying this Pull Request
The heading is translated
Link to documentations
Please select: