Skip to content

Conversation

@Hackwar
Copy link
Member

@Hackwar Hackwar commented Jul 12, 2024

Summary of Changes

The LegacyErrorHandlingTrait is part of our legacy error handling, which has been deprecated since Joomla 3.1 already. In an effort to remove this finally from the core, this PR removes the trait from the CategoryNode and Changelog class, since they are NOT used in those classes anyway. This is a b/c break and thus has to go into 6.0.

Testing Instructions

Codereview.

Link to documentations

Please select:

@Hackwar Hackwar added the b/c break This item changes the behavior in an incompatible why. HEADS UP label Jul 12, 2024
@rdeutz
Copy link
Contributor

rdeutz commented Aug 14, 2024

This needs to be documented in the manual/Release Notes.

@Bodge-IT
Copy link
Contributor

Hi @Hackwar, please can you add the PR for the manual?

@Hackwar
Copy link
Member Author

Hackwar commented Feb 12, 2025

Done.

@Bodge-IT
Copy link
Contributor

Bodge-IT commented Mar 3, 2025

I have tested this item ✅ successfully on f94aec5

Tested multi-cat create/move/copy process. All variants worked.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43777.

@softforge
Copy link
Contributor

I have tested this item ✅ successfully on f94aec5

Tested 6.0 site before and after the patch was added. No change to behaviour


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43777.

@softforge softforge added this to the Joomla! 6.0.0 milestone Mar 3, 2025
@softforge softforge merged commit 8d8451b into joomla:6.0-dev Mar 3, 2025
4 checks passed
@Hackwar Hackwar deleted the 6.0-categorynode branch March 5, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

b/c break This item changes the behavior in an incompatible why. HEADS UP Feature PR-6.0-dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants