[4.4] Fix display of total votes

[Quy]

Pull Request for Issue #43728. Regression of #42934.

Summary of Changes

Move the number of votes outside of the visually-hidden section so it can be visible.

Testing Instructions

Enable Voting in Articles component configuration.
Vote for one or more articles.

Edit Content -Vote plugin.
Toggle Number of Votes to Show.

Actual result BEFORE applying this Pull Request

Total number of votes is not visible.

Expected result AFTER applying this Pull Request

Total number of votes is visible.

[chmst]

The whole block after <?php if ($rcount) : ?>needs to be indented

[ChristineWk]

I have tested this item ✅ successfully on 9ed4867

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43740.}

[viocassel]

I have tested this item ✅ successfully on 9ed4867

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43740.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43740.}

[brianteeman]

The whole block after <?php if ($rcount) : ?>needs to be indented

How can this be rtc while this is still outstanding to be fixed

[richard67]

The whole block after <?php if ($rcount) : ?>needs to be indented

How can this be rtc while this is still outstanding to be fixed

To me the code style seems to be ok, and PHPCS seems to be ok with it, too.

[sandewt]

Thanks for this PR and testing.

Just a question. Who or what ensures that this PR also applies to J5?

[richard67]

Thanks for this PR and testing.

Just a question. Who or what ensures that this PR also applies to J5?

@sandewt Same as always for all bug fixes in 4.4-dev: When the PR has been merged into 4.4-dev, release managers of 5.1 will merge it up into 5.1-dev and so on.

[brianteeman]

The whole block after <?php if ($rcount) : ?>needs to be indented

How can this be rtc while this is still outstanding to be fixed

To me the code style seems to be ok, and PHPCS seems to be ok with it, too.

when you look at the entire file (not just the snippet shown in github) then you can see that @chmst is correct

[richard67]

@Quy Thanks for fixing the CS.

Leaving RTC status as the change after setting RTC was just a code style change, so previous human tests are still valid.

@chmst Thanks for review, and thanks @ChristineWk and @viocassel for testing.

[MacJoom]

Thank you!