[5.3] [Events] Use event classes for System plugins#43637
Merged
laoneo merged 29 commits intojoomla:5.3-devfrom Feb 5, 2025
Merged
[5.3] [Events] Use event classes for System plugins#43637laoneo merged 29 commits intojoomla:5.3-devfrom
laoneo merged 29 commits intojoomla:5.3-devfrom
Conversation
Member
|
@Fedik System tests are failing in Drone when trying to delete a user and waiting for the content "User deleted." appearing in the in the system-message-container div. |
Member
|
This pull request has been automatically rebased to 5.3-dev. |
Conflicts: plugins/system/highlight/src/Extension/Highlight.php
Conflicts: plugins/system/actionlogs/src/Extension/ActionLogs.php
Conflicts: plugins/system/jooa11y/src/Extension/Jooa11y.php
joomdonation
suggested changes
Feb 5, 2025
Contributor
joomdonation
left a comment
There was a problem hiding this comment.
Some changes are needed. Some changes are nice to have
joomdonation
reviewed
Feb 5, 2025
joomdonation
reviewed
Feb 5, 2025
Contributor
joomdonation
left a comment
There was a problem hiding this comment.
Just some other small changes and we should be fine. Thanks !
Contributor
|
Thanks, all good now from my code review and basic test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Update
systemplugins to useSubscriberInterfaceand event classes.Testing Instructions
Check following
systemplugins should work as before:Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select: