Skip to content

[a11y] Fix missing aria-label in pagenavigation #43600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MacJoom merged 5 commits into from
Jun 14, 2024
Merged

[a11y] Fix missing aria-label in pagenavigation #43600

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
758cbda
fix missing areialabel in pagenavigation
chmst Jun 2, 2024
efcec52
Better aria-label
chmst Jun 2, 2024
6ec6e91
loadlanguage
chmst Jun 2, 2024
aab5d65
Update plugins/content/pagenavigation/tmpl/default.php
chmst Jun 2, 2024
933aa31
Merge branch '4.4-dev' into a11y-pagenavigation-arialabel
MacJoom Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions administrator/language/en-GB/plg_content_pagenavigation.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
; Note : All ini files need to be saved as UTF-8

PLG_CONTENT_PAGENAVIGATION="Content - Page Navigation"
PLG_PAGENAVIGATION_ARIA_LABEL="Page Navigation"
PLG_PAGENAVIGATION_FIELD_DISPLAY_LABEL="Link Text"
PLG_PAGENAVIGATION_FIELD_POSITION_LABEL="Position"
PLG_PAGENAVIGATION_FIELD_RELATIVE_LABEL="Relative To"
Expand Down
4 changes: 3 additions & 1 deletion plugins/content/pagenavigation/tmpl/default.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,12 @@
use Joomla\CMS\Language\Text;
use Joomla\CMS\Router\Route;

$this->loadLanguage();

$lang = $this->getLanguage();
?>

<nav class="pagenavigation">
<nav class="pagenavigation" aria-label="<?php echo Text::_('PLG_PAGENAVIGATION_ARIA_LABEL'); ?>">
<span class="pagination ms-0">
<?php if ($row->prev) :
$direction = $lang->isRtl() ? 'right' : 'left'; ?>
Expand Down