Skip to content

Conversation

@Fedik
Copy link
Member

@Fedik Fedik commented May 30, 2024

Pull Request for Issue #43561 .

Summary of Changes

Fix multiselect to not to interfere with interactive elements.

Testing Instructions

Run npm install.

Edit

Add:

<details>
  <summary>Details</summary>
  Something small enough to escape casual notice.
</details>

Got to Articles overview /administrator/index.php?option=com_content&view=articles
And click on "Details" in each row.

Actual result BEFORE applying this Pull Request

The row become selected/unselected after each click

Expected result AFTER applying this Pull Request

The row stay unselected.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.4-dev labels May 30, 2024
@Fedik Fedik added the bug label May 30, 2024
@Fedik Fedik linked an issue May 30, 2024 that may be closed by this pull request
@rogercreagh
Copy link

I have tested this item ✅ successfully on 9ca0d32

Yep this seems to fix the problem with <details> elements and also <a> with html tags inside the text. Good job.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43574.

@Quy
Copy link
Contributor

Quy commented Jul 7, 2024

I have tested this item ✅ successfully on 9ca0d32


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43574.

@Quy
Copy link
Contributor

Quy commented Jul 7, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43574.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 7, 2024
@MacJoom MacJoom self-assigned this Jul 10, 2024
@MacJoom MacJoom added this to the Joomla! 4.4.7 milestone Aug 5, 2024
@MacJoom MacJoom merged commit 789ed19 into joomla:4.4-dev Aug 5, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 5, 2024
@MacJoom
Copy link
Contributor

MacJoom commented Aug 5, 2024

Thank you!

@Fedik Fedik deleted the fix-multiselect-intercative-els branch August 5, 2024 14:00
dgrammatiko pushed a commit to dgrammatiko/joomla-cms that referenced this pull request Aug 11, 2024
dgrammatiko pushed a commit to dgrammatiko/joomla-cms that referenced this pull request Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.4-dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

multiselect.js issue with unwanted selections

6 participants