Skip to content

[5.3] Add option for show/hide title in readmore#43457

Merged
drmenzelit merged 9 commits intojoomla:5.3-devfrom
rdeutz:readmore-off-title
Oct 16, 2024
Merged

[5.3] Add option for show/hide title in readmore#43457
drmenzelit merged 9 commits intojoomla:5.3-devfrom
rdeutz:readmore-off-title

Conversation

@rdeutz
Copy link
Contributor

@rdeutz rdeutz commented May 11, 2024

Pull Request for Issue #34609 .

Summary of Changes

Adding an option to the newsflash module to show, hide use global setting for the text at the read more button

Testing Instructions

  1. Read the issue and confirm the issue on Joomla 5.2 with sample data
  2. apply patch
  3. go to the "Latest Posts" module
  4. change the "Read More with Title" options in the module and check if the hide/show have the effect we want
  5. change the "Read More with Title" options in the module to "Use global article settings"
  6. go to content -> options and change under articles the Read More with Title and check if the hide/show have the effect we want

Actual result BEFORE applying this Pull Request

See issue

Expected result AFTER applying this Pull Request

You can control from the newflash module what text is at the read more button in the newsflash module

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@KingLouis1
Copy link

I have not tested this item.

Not able to test, as instruction not clear. Where ist this module?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43457.

@crimle
Copy link

crimle commented Jul 15, 2024

I am bewildered. First you mention the «newsflash module». Later you ask «go to the "Latest Posts" module». I was unable to test thoroughly.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43457.

@Quy
Copy link
Contributor

Quy commented Jul 15, 2024

Please test with the Articles - Newsflash module.

@crimle
Copy link

crimle commented Jul 16, 2024

I have tested this item ✅ successfully on 0a2af87

Should be
3. go to the "Articles - Newsflash" module
NOT 3. go to the "Latest Posts" module
then the testing instructions are comprehensible. My tests were successful.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43457.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 0a2af87


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43457.

@richard67
Copy link
Member

@rdeutz Could you check the changes suggested by @Quy ?

@Quy Quy added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Aug 10, 2024
@pcombet-adosis
Copy link

Hello,
tested, it does work ✅
I have tested it in a Multi language environment (FR/ENG)
All clear
Best
Phil

@richard67
Copy link
Member

Hello, tested, it does work ✅ I have tested it in a Multi language environment (FR/ENG) All clear Best Phil

@pcombet-adosis Please go to the issue tracker here https://issues.joomla.org/tracker/joomla-cms/43457 and mark your test result by using the blue "Test this" button at the top left corner, selecting your test result and finally submit, so that your test is properly counted. Just a comment with a green check mark is not enough. Thanks in advance.

@pcombet-adosis
Copy link

I have tested this item ✅ successfully on 0a2af87

I have tested it in a Multi language environment (FR/ENG)
All clear

Best
Philippe


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43457.

@crommie
Copy link

crommie commented Aug 24, 2024

I have tested this item ✅ successfully on 0a2af87

Works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43457.

@softforge
Copy link
Contributor

I have tested this item ✅ successfully on 0a2af87

Did what it says on the tin


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43457.

rdeutz and others added 2 commits August 24, 2024 11:38
Co-authored-by: Quy <quy@nomonkeybiz.com>
Co-authored-by: Quy <quy@nomonkeybiz.com>
@joomla-cms-bot joomla-cms-bot removed the Language Change This is for Translators label Aug 24, 2024
@richard67 richard67 added Language Change This is for Translators Updates Requested Indicates that this pull request needs an update from the author and should not be tested. and removed Updates Requested Indicates that this pull request needs an update from the author and should not be tested. labels Aug 24, 2024
@richard67
Copy link
Member

As the last change after the successful human tests did just change the language string to the already existing global string, which is already used elsewhere in the same XML, which I've just checked by review, the previous human tests are still valid => RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43457.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 24, 2024
@richard67 richard67 removed Language Change This is for Translators Updates Requested Indicates that this pull request needs an update from the author and should not be tested. labels Aug 24, 2024
@HLeithner HLeithner changed the base branch from 5.2-dev to 5.3-dev September 2, 2024 08:51
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.3-dev.

@HLeithner HLeithner changed the title [5.2]Add option for show/hide title in readmore [5.3] Add option for show/hide title in readmore Sep 2, 2024
@Hackwar Hackwar removed the PR-5.2-dev label Sep 3, 2024
@drmenzelit drmenzelit merged commit a2a909c into joomla:5.3-dev Oct 16, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 16, 2024
@Quy Quy added this to the Joomla! 5.3.0 milestone Oct 16, 2024
@rdeutz rdeutz deleted the readmore-off-title branch May 14, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Comments