Skip to content

Conversation

@Hackwar
Copy link
Member

@Hackwar Hackwar commented Apr 28, 2024

Summary of Changes

When the route of an entry in Smart Search isn't a query string, the highlight feature actually can produce invalid URLs. This PR enforces these URLs to be correct.

Testing Instructions

Look at #43397, apply that patch and get the testing plugin. Index an RTF file and search in the frontend for this entry in the search. Click on the URL.

Actual result BEFORE applying this Pull Request

The URL looks something like /tolstoy.rtf&highlight=bunchofbase64gibberish and throws a 404 when clicked.

Expected result AFTER applying this Pull Request

The URL looks something like /tolstoy.rtf?highlight=bunchofbase64gibberish and does not throw a 404 when clicked.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@webnet-assmann
Copy link

I have tested this item ✅ successfully on a5bd855


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43398.

@Hackwar Hackwar removed the Feature label Aug 28, 2024
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on a5bd855


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43398.

@Quy Quy added the Feature label Nov 3, 2024
@Quy
Copy link
Contributor

Quy commented Nov 3, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43398.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 3, 2024
@pe7er pe7er self-assigned this Nov 7, 2024
@pe7er pe7er enabled auto-merge (squash) November 7, 2024 13:21
@pe7er pe7er merged commit 7802043 into joomla:5.2-dev Nov 7, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 7, 2024
@pe7er pe7er added this to the Joomla! 5.2.1 milestone Nov 7, 2024
@pe7er
Copy link
Contributor

pe7er commented Nov 7, 2024

Thanks @Hackwar !

@Hackwar Hackwar deleted the 5.2-finder-highlight branch November 24, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants