[6.0] Custom Fields: Correcting typehint for $this in layout#43357
Merged
HLeithner merged 4 commits intojoomla:6.0-devfrom May 22, 2024
Merged
[6.0] Custom Fields: Correcting typehint for $this in layout#43357HLeithner merged 4 commits intojoomla:6.0-devfrom
HLeithner merged 4 commits intojoomla:6.0-devfrom
Conversation
Contributor
|
@HLeithner could it be that we need to merge the 5.2-dev to 6.0-dev first? |
Member
|
yes, but didn't head the time yet |
Contributor
|
Done: #43515 |
Member
|
Merged in 6.0 to prevent override notification system, thanks |
HLeithner
changed the title
Member
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
When adding typehints for these custom fields, I mistakenly used the FileLayout class, while it actually is the respective plugins class.
Testing Instructions
Codereview.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed