[5.1] Use update channel the correct way#43190
Merged
LadySolveig merged 21 commits intojoomla:5.1-devfrom Apr 2, 2024
Merged
Conversation
brianteeman
reviewed
Apr 1, 2024
brianteeman
reviewed
Apr 1, 2024
Co-authored-by: Brian Teeman <brian@teeman.net>
Contributor
|
I have tested this item ✅ successfully on e9e03f8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43190. |
2 tasks
Member
|
@bembelimen It seems this PR breaks the unit tests for the constraint checker. |
Quy
reviewed
Apr 1, 2024
Member
|
Why did you revert the final statement? Sounds logic to me instead of the long description that this class is internal only. |
Contributor
Author
|
I'm not keen to rewrite and fix all the tests, when I declare them as final (plus, I don't like to close classes that way). Feel free to look into it, but I don't plan to do it before the RC. |
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternatives for #43184