Skip to content

[5.1] Use update channel the correct way#43190

Merged
LadySolveig merged 21 commits intojoomla:5.1-devfrom
bembelimen:5.1/tuf-checker
Apr 2, 2024
Merged

[5.1] Use update channel the correct way#43190
LadySolveig merged 21 commits intojoomla:5.1-devfrom
bembelimen:5.1/tuf-checker

Conversation

@bembelimen
Copy link
Contributor

@bembelimen bembelimen commented Apr 1, 2024

Alternatives for #43184

@LadySolveig
Copy link
Contributor

I have tested this item ✅ successfully on e9e03f8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43190.

@richard67
Copy link
Member

@bembelimen It seems this PR breaks the unit tests for the constraint checker.

@laoneo
Copy link
Member

laoneo commented Apr 2, 2024

Why did you revert the final statement? Sounds logic to me instead of the long description that this class is internal only.

@bembelimen
Copy link
Contributor Author

I'm not keen to rewrite and fix all the tests, when I declare them as final (plus, I don't like to close classes that way). Feel free to look into it, but I don't plan to do it before the RC.

@LadySolveig LadySolveig merged commit 5bcc433 into joomla:5.1-dev Apr 2, 2024
@LadySolveig
Copy link
Contributor

Thank you!

@bembelimen bembelimen deleted the 5.1/tuf-checker branch December 9, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants