Skip to content

Comments

[4.4] User profile edit: No notice when no active menu item#43140

Merged
laoneo merged 2 commits intojoomla:4.4-devfrom
Hackwar:4.4-profile-menuitem
Mar 27, 2024
Merged

[4.4] User profile edit: No notice when no active menu item#43140
laoneo merged 2 commits intojoomla:4.4-devfrom
Hackwar:4.4-profile-menuitem

Conversation

@Hackwar
Copy link
Member

@Hackwar Hackwar commented Mar 24, 2024

Pull Request for Issue #40499 .

Summary of Changes

When there is not active menu item and you edit your user profile, you get a notice at the top.

Testing Instructions

  1. Enable error reporting
  2. Make sure you have no menu item pointing to the user profile view or the profile edit view.
  3. Login to the frontend
  4. Go to index.php?option=com_users&view=profile&layout=edit&Itemid=444444 (The 444444 is supposed to be a non-existing menu item)

Actual result BEFORE applying this Pull Request

You get a notice about accessing query on null.

Expected result AFTER applying this Pull Request

No notice.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Quy
Copy link
Contributor

Quy commented Mar 26, 2024

I have tested this item ✅ successfully on 392c07a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43140.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 392c07a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43140.

@Quy
Copy link
Contributor

Quy commented Mar 26, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43140.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 26, 2024
@laoneo laoneo added this to the Joomla! 4.4.4 milestone Mar 27, 2024
@laoneo laoneo merged commit 9d5b5a2 into joomla:4.4-dev Mar 27, 2024
@laoneo
Copy link
Member

laoneo commented Mar 27, 2024

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 27, 2024
@Hackwar Hackwar deleted the 4.4-profile-menuitem branch June 10, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants