[4.4] User profile edit: No notice when no active menu item#43140
Merged
laoneo merged 2 commits intojoomla:4.4-devfrom Mar 27, 2024
Merged
[4.4] User profile edit: No notice when no active menu item#43140laoneo merged 2 commits intojoomla:4.4-devfrom
laoneo merged 2 commits intojoomla:4.4-devfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on 392c07a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43140. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 392c07a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43140. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43140. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #40499 .
Summary of Changes
When there is not active menu item and you edit your user profile, you get a notice at the top.
Testing Instructions
index.php?option=com_users&view=profile&layout=edit&Itemid=444444(The 444444 is supposed to be a non-existing menu item)Actual result BEFORE applying this Pull Request
You get a notice about accessing query on null.
Expected result AFTER applying this Pull Request
No notice.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed