Skip to content

[5.1] GuidedTours: No error when joomla-welcome is missing#43139

Merged
LadySolveig merged 3 commits intojoomla:5.1-devfrom
Hackwar:5.1-guidedtour
Mar 27, 2024
Merged

[5.1] GuidedTours: No error when joomla-welcome is missing#43139
LadySolveig merged 3 commits intojoomla:5.1-devfrom
Hackwar:5.1-guidedtour

Conversation

@Hackwar
Copy link
Member

@Hackwar Hackwar commented Mar 24, 2024

Summary of Changes

When an update of Joomla failed and the joomla-welcome guided tour wasn't added to the database, a big warning is displayed at the top of the backend dashboard. This PR adds another check to make sure we loaded anything in the first place before accessing it.

Testing Instructions

  1. Install Joomla
  2. Delete the joomla-welcome from #__guidedtours
  3. Login to the backend.

Actual result BEFORE applying this Pull Request

Big warning at the top of the screen.

Expected result AFTER applying this Pull Request

No warning.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@obuisard
Copy link
Contributor

I have tested this item ✅ successfully on 8036900


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43139.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Mar 24, 2024

I have tested this item ✅ successfully on 8036900


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43139.

@Quy
Copy link
Contributor

Quy commented Mar 24, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43139.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 24, 2024
@Quy Quy added this to the Joomla! 5.1.0 milestone Mar 24, 2024
@LadySolveig LadySolveig merged commit 344d590 into joomla:5.1-dev Mar 27, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 27, 2024
@LadySolveig
Copy link
Contributor

Thank you @Hackwar and also for testing @obuisard and @Quy

@Hackwar Hackwar deleted the 5.1-guidedtour branch June 10, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants