[5.1] Cog icon focus [a11y]

[brianteeman]

adds an outline to the cog when it receives keyboard focus

Pull Request for Issue #43066 .

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[Quy]

I have tested this item ✅ successfully on 9bcda96

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43135.}

[viocassel]

I have tested this item ✅ successfully on 9bcda96

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43135.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43135.}

[brianteeman]

thanks @wilsonge

[wilsonge]

Thanks!

[bembelimen]

This PR is not optimal, because the selector is too generic. Now all buttons in the cpanel which are the first child get this effect. It should be either reverted or fixed (by being more specific).

[brianteeman]

can you provide an example please so I can check

[brianteeman]

From what I can see the only button that can ever match the selector is the cog - what am I missing?

[bembelimen]

It selected every item with the class "btn" which is the first child. So if a module has a btn, it gets the styling, too.

[chmst]

My concern is that a second button (for a custom module) does not get the focus-ring

[brianteeman]

It selected every item with the class "btn" which is the first child. So if a module has a btn, it gets the styling, too.

demonstrably not true, otherwise the buttons in the sample data module would have the outline

My concern is that a second button (for a custom module) does not get the focus-ring

Please show an example