[5.1] Fix Sample data installation, fix finder helper addContentType null value#43051
Closed
Fedik wants to merge 1 commit intojoomla:5.1-devfrom
Closed
[5.1] Fix Sample data installation, fix finder helper addContentType null value#43051Fedik wants to merge 1 commit intojoomla:5.1-devfrom
Fedik wants to merge 1 commit intojoomla:5.1-devfrom
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Helper::addContentType() allows null for mime however $db->quote() does not.
Testing Instructions
Use PHP 8+
On clean installation, set error reaporting to Maximum
Then try install "Blog Sample Data"
Actual result BEFORE applying this Pull Request
An error
There is an error in a sample data plugin ...Expected result AFTER applying this Pull Request
All works
Link to documentations
Please select: