[5.1] Revert implementation of AfterInitialiseRouterEvent

[Hackwar]

Pull Request for Issue #42991.

Summary of Changes

In an ideal world, the site router would only be created when necessary with the previously added onAfterInitialiseRouter event. However if a system plugin requests the site router object before all constructors of system plugins have run, the event would be fired, but no plugin would react to it, since the events haven't been registered yet. Since we can't guarantee that no one requests the router object prematurely, we have to revert the code and load the site router regardless of the application executed.

Testing Instructions

1. Edit plugins/system/redirect/services/provider.php and insert $container->get(\Joomla\CMS\Router\SiteRouter::class); at line 43 (after '$plugin->setDatabase($container->get(DatabaseInterface::class));')
2. Make sure the languagefilter plugin is enabled
3. Open any page

Actual result BEFORE applying this Pull Request

The page throws an error.

Expected result AFTER applying this Pull Request

The page works fine.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[SniperSister]

I have tested this item ✅ successfully on 479dcac

Works as described. For more info see my test comments in #43015

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43009.}

[richard67]

@Hackwar Does this close issue #42991 ?

[Hackwar]

yes

[Fedik]

I have tested this item ✅ successfully on 479dcac

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43009.}

[Fedik]

r2c

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43009.}

[LadySolveig]

Thank you @Hackwar and for the support and testing @Fedik @SniperSister