Skip to content

Conversation

@heelc29
Copy link
Contributor

@heelc29 heelc29 commented Mar 4, 2024

Summary of Changes

remove deprecated language strings - added again due merge conflict in #42950 @LadySolveig @bembelimen
https://github.com/joomla/joomla-cms/pull/42950/files#diff-c958054a01e06914ff9d8d8f3f34f6eafac053a8927e6e3bfb51ceaaa7c39a3e

Now the two strings exist twice

PLG_SYSTEM_PRIVACYCONSENT_CACHETIMEOUT_DESC="How often the check is performed."
PLG_SYSTEM_PRIVACYCONSENT_CACHETIMEOUT_LABEL="Periodic check (days)"

PLG_SYSTEM_PRIVACYCONSENT_CACHETIMEOUT_DESC="How often the check is performed."
PLG_SYSTEM_PRIVACYCONSENT_CACHETIMEOUT_LABEL="Periodic check (days)"

Testing Instructions

code review

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.1-dev labels Mar 4, 2024
@bembelimen bembelimen added this to the Joomla! 5.1.0 milestone Mar 4, 2024
@ceford
Copy link
Contributor

ceford commented Mar 5, 2024

I have tested this item ✅ successfully on 0a7a5f3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42953.

@LadySolveig LadySolveig changed the title [5.1] remove deprecated language strings [5.1] remove deprecated language strings from up-merge #42950 Mar 5, 2024
@Quy
Copy link
Contributor

Quy commented Mar 5, 2024

I have tested this item ✅ successfully on 0a7a5f3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42953.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 5.1.0 milestone Mar 5, 2024
@Quy
Copy link
Contributor

Quy commented Mar 5, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42953.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 5, 2024
Copy link
Contributor

@tecpromotion tecpromotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @heelc29

@LadySolveig LadySolveig merged commit d6a41ed into joomla:5.1-dev Mar 6, 2024
@LadySolveig
Copy link
Contributor

Thank you @heelc29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants