Skip to content

[5.3] Remove unsed variable messages from enqueue messages #42948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laoneo merged 7 commits into from
Feb 28, 2025
Merged

[5.3] Remove unsed variable messages from enqueue messages #42948

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
47c3df5
Remove unsed variable
chmst Mar 4, 2024
1a57b41
fix as reuested
chmst Mar 4, 2024
b950f38
Add a comment
chmst Mar 4, 2024
8218b4b
Merge branch '4.4-dev' into enqueue-messages-unused-variabe
laoneo Mar 4, 2024
208df7a
Merge branch '5.2-dev' into enqueue-messages-unused-variabe
chmst Jul 20, 2024
26125e1
Merge branch '5.3-dev' into enqueue-messages-unused-variabe
bembelimen Feb 22, 2025
7595d96
Merge branch '5.3-dev' into enqueue-messages-unused-variabe
laoneo Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions libraries/src/Application/CMSApplication.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,10 +249,8 @@ public function enqueueMessage($msg, $type = self::MSG_INFO)
'type' => $inputFilter->clean(strtolower($type), 'cmd'),
];

// For empty queue, if messages exists in the session, enqueue them first.
$messages = $this->getMessageQueue();

if (!\in_array($message, $this->messageQueue)) {
// Get the messages of the session and add the new message if it is not already in the queue.
if (!\in_array($message, $this->getMessageQueue())) {
// Enqueue the message.
$this->messageQueue[] = $message;
}
Expand Down