[5.1] replace app property in SEF plugin#42926
Closed
heelc29 wants to merge 1 commit intojoomla:5.1-devfrom
Closed
[5.1] replace app property in SEF plugin#42926heelc29 wants to merge 1 commit intojoomla:5.1-devfrom
heelc29 wants to merge 1 commit intojoomla:5.1-devfrom
Conversation
wilsonge
approved these changes
Feb 29, 2024
Contributor
|
#42932 includes these fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup Pull Request for PRs #42702 and #42704 . @Hackwar
Summary of Changes
replace extra app property and replace with injected application due service provider
Testing Instructions
check new options (#42702 and #42704) are still working as expected
Actual result BEFORE applying this Pull Request
app property in plugins are deprecated
joomla-cms/libraries/src/Plugin/CMSPlugin.php
Lines 137 to 145 in 8da0b7c
Expected result AFTER applying this Pull Request
no deprecated app property is used in sef plugin
Link to documentations
Please select: