[4.4] Smart Search, limit the highlight#42921
Merged
laoneo merged 1 commit intojoomla:4.4-devfrom Mar 4, 2024
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on 84c7fde This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42921. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 84c7fde This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42921. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42921. |
Member
|
Sorry, but we have this already in the layout of smart search. https://github.com/joomla/joomla-cms/blob/4.4-dev/components/com_finder/tmpl/search/default_results.php#L64 I don't think it is useful to duplicate this code here as well. |
Member
Author
|
@Hackwar nope, it is diferent, it is for URL. What is in your PR is for JavaScript. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #42889
Summary of Changes
Same as #41463 but for
highlightpluginTesting Instructions
In testing installation.
In Smart Search config set "Word Match" to "Match words containing the search term anywhere".
Go to search page, and search for
joomla 1.Notice the length of the link for each search result.
Actual result BEFORE applying this Pull Request
it is long
Expected result AFTER applying this Pull Request
it is shorter
Link to documentations
Please select: