Skip to content

Conversation

@Hackwar
Copy link
Member

@Hackwar Hackwar commented Feb 27, 2024

Summary of Changes

Unfortunately I made a mistake in #42692 by not converting all events to the new SubscriberInterface, making the languagefilter plugin fail in some areas. This PR fixes that.

Testing Instructions

  1. Enable the languagefilter plugin
  2. Edit your profile, for example in the backend
  3. Click on save.

Actual result BEFORE applying this Pull Request

Error

Expected result AFTER applying this Pull Request

No error.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Feb 27, 2024
@dautrich
Copy link

I have tested this item ✅ successfully on d1068f7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42901.

1 similar comment
@joomdonation
Copy link
Contributor

I have tested this item ✅ successfully on d1068f7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42901.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 5.1.0 milestone Feb 27, 2024
@joomdonation
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42901.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 27, 2024
@LadySolveig LadySolveig merged commit 94e86db into joomla:5.1-dev Feb 27, 2024
@LadySolveig
Copy link
Contributor

Thank you @Hackwar 🚀 and also to the fast and diligent testers @dautrich and @joomdonation

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 27, 2024
@Quy Quy added this to the Joomla! 5.1.0 milestone Feb 27, 2024
@Hackwar Hackwar deleted the 5.1-languagefilter branch March 4, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants