Skip to content

Conversation

@C-Lodder
Copy link
Member

@C-Lodder C-Lodder commented Feb 8, 2024

Summary of Changes

This PR removes the jQuery dependency for the treeselect Javascript.

Also uses a <div> for the dropdown heading, as opposed to a <h1>.

Testing Instructions

  1. Go to edit any module in the Module Manager.
  2. Navigate to the "Menu Assignment" tab
  3. Select "Only on the pages selected"
  4. Play around with all the treeselect options (expanding, collapsing, checking, unchecking, etc)

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev labels Feb 8, 2024
@ghost
Copy link

ghost commented Feb 8, 2024

I have tested this item ✅ successfully on 29ae5d3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42776.

@Fedik Fedik added the Feature label Feb 8, 2024
@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Feb 9, 2024
@Fedik
Copy link
Member

Fedik commented Feb 12, 2024

I have tested this item ✅ successfully on 4f775be


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42776.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 5.1.0 milestone Feb 12, 2024
@Fedik
Copy link
Member

Fedik commented Feb 12, 2024

r2c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42776.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 12, 2024
@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Feb 25, 2024
@LadySolveig
Copy link
Contributor

Thank you for your work @C-Lodder I tested this and as soon as an individual menu item has been manually selected/deselected, the dropdown next to it for the entire menu for "selecting/deselecting" all menu items no longer has any effect on the previously manually changed entry.
Only again after the complete page refresh.
However, this error already exists in the old version.
Could you please take a look here?

@LadySolveig LadySolveig added Updates Requested Indicates that this pull request needs an update from the author and should not be tested. RTC This Pull Request is Ready To Commit and removed RTC This Pull Request is Ready To Commit Updates Requested Indicates that this pull request needs an update from the author and should not be tested. labels Feb 25, 2024
@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 5.1.0 milestone Feb 25, 2024
@LadySolveig LadySolveig added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Feb 25, 2024
@C-Lodder
Copy link
Member Author

C-Lodder commented Feb 26, 2024

@LadySolveig Can do, but the toolbar in the edit view is missing. I this a known bug with the recent upmerge?

image

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 26, 2024
@Fedik
Copy link
Member

Fedik commented Feb 26, 2024

but the toolbar in the edit view is missing

Clear the cache for autoload_psr4.php

@C-Lodder
Copy link
Member Author

@LadySolveig Good catch. Fixed now

@LadySolveig
Copy link
Contributor

Thank you @C-Lodder for your quick response and the fix.
I'm very happy that you were able to fix this bug that has been around for a while!

@LadySolveig LadySolveig merged commit 4dbea00 into joomla:5.1-dev Feb 26, 2024
@LadySolveig
Copy link
Contributor

Thank you for your work @C-Lodder and also to the testers and support @fgsw @Fedik @dgrammatiko

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature NPM Resource Changed This Pull Request can't be tested by Patchtester Updates Requested Indicates that this pull request needs an update from the author and should not be tested.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants