-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[5.1] Rewrite treeselect in vanilla JS #42776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I have tested this item ✅ successfully on 29ae5d3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42776. |
Co-authored-by: Dimitris Grammatikogiannis <[email protected]>
|
I have tested this item ✅ successfully on 4f775be This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42776. |
|
r2c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42776. |
|
Thank you for your work @C-Lodder I tested this and as soon as an individual menu item has been manually selected/deselected, the dropdown next to it for the entire menu for "selecting/deselecting" all menu items no longer has any effect on the previously manually changed entry. |
|
@LadySolveig Can do, but the toolbar in the edit view is missing. I this a known bug with the recent upmerge? |
Clear the cache for autoload_psr4.php |
|
@LadySolveig Good catch. Fixed now |
|
Thank you @C-Lodder for your quick response and the fix. |
|
Thank you for your work @C-Lodder and also to the testers and support @fgsw @Fedik @dgrammatiko |

Summary of Changes
This PR removes the jQuery dependency for the treeselect Javascript.
Also uses a
<div>for the dropdown heading, as opposed to a<h1>.Testing Instructions