Change the getItem return type to stdClass and make the CMSObject inherit it#42717
Merged
LadySolveig merged 4 commits intojoomla:5.1-devfrom Feb 27, 2024
Merged
Conversation
4 tasks
|
I have tested this item ✅ successfully on 080cca9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42717. |
Contributor
|
I have tested this item ✅ successfully on 080cca9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42717. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42717. |
Contributor
|
Thank you @laoneo and also for testing @crommie and @viocassel |
HLeithner
added a commit
to joomla/Manual
that referenced
this pull request
Mar 5, 2024
getItem change for joomla/joomla-cms#42717
This was referenced Mar 5, 2024
This was referenced Mar 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
To get away from the CMSObject class we need a step by step process in the getItem function of the admin model. Alternative to #42714 which makes the
CMSObjectastdClassand changes the return type to it. It is a more lightweight solution as no new deprecated flag is introduced. It has basically the same effect as when we change the flag in 6.0.Testing Instructions
Create an article in the back end. With as many content plugins as possible.
Actual result BEFORE applying this Pull Request
All works.
Expected result AFTER applying this Pull Request
All works.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: getItem change for https://github.com/joomla/joomla-cms/pull/42717 Manual#232
No documentation changes for manual.joomla.org needed