Skip to content

Change the getItem return type to stdClass and make the CMSObject inherit it#42717

Merged
LadySolveig merged 4 commits intojoomla:5.1-devfrom
Digital-Peak:model/admin/getitem2
Feb 27, 2024
Merged

Change the getItem return type to stdClass and make the CMSObject inherit it#42717
LadySolveig merged 4 commits intojoomla:5.1-devfrom
Digital-Peak:model/admin/getitem2

Conversation

@laoneo
Copy link
Member

@laoneo laoneo commented Jan 27, 2024

Summary of Changes

To get away from the CMSObject class we need a step by step process in the getItem function of the admin model. Alternative to #42714 which makes the CMSObject a stdClass and changes the return type to it. It is a more lightweight solution as no new deprecated flag is introduced. It has basically the same effect as when we change the flag in 6.0.

Testing Instructions

Create an article in the back end. With as many content plugins as possible.

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

Link to documentations

Please select:

@laoneo laoneo changed the title Change the getItem return type to stdClass abd make the CMSObject inherit it Change the getItem return type to stdClass and make the CMSObject inherit it Jan 31, 2024
@crommie
Copy link

crommie commented Feb 24, 2024

I have tested this item ✅ successfully on 080cca9

I've created an article with a number of custom fields and schema stuff. No difference before / after patch so I guess it works.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42717.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 080cca9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42717.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42717.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 24, 2024
@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Feb 27, 2024
@LadySolveig LadySolveig merged commit 91a6c4c into joomla:5.1-dev Feb 27, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 27, 2024
@LadySolveig
Copy link
Contributor

Thank you @laoneo and also for testing @crommie and @viocassel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants