Update Nested.php to support aliasing the 'checked_out' column.#42697
Merged
MacJoom merged 3 commits intojoomla:4.4-devfrom Feb 5, 2024
Merged
Update Nested.php to support aliasing the 'checked_out' column.#42697MacJoom merged 3 commits intojoomla:4.4-devfrom
MacJoom merged 3 commits intojoomla:4.4-devfrom
Conversation
Removed hard-coded references to the 'checked_out' database column and replaced them with variables containing the column alias, obtained through a $this->getColumnAlias() call. Now, the 'checked_out' column references mirror the 'published' column references in their respect for column aliasing.
Contributor
|
I have tested this item ✅ successfully on 91c827d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42697. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 91c827d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42697. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42697. |
Contributor
|
Thank you! |
Contributor
Author
You're quite welcome--it's so nice to be able to give back, even if in just this tiny way. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed hard-coded references to the 'checked_out' database column and replaced them with variables containing the column alias, obtained through a $this->getColumnAlias() call. Now, the 'checked_out' column references mirror the 'published' column references in their respect for column aliasing.
Pull Request for Issue #42688 .
Summary of Changes
Removed hard-coded references to the 'checked_out' database column and replaced them with variables containing the column alias, obtained through a $this->getColumnAlias() call. Now, the 'checked_out' column references mirror the 'published' column references in their respect for column aliasing. Also made sure the '=' operators lined up nicely in the variable declaration/initialization lines while I was at it.
Testing Instructions
Change the published state of one or more items whose data are stored in a nested table, i.e. the Tags component to ensure the change did not break existing functionality. To verify new support for aliasing, instantiate the class and call the publish() method from a client that uses an alias for the 'checked_out' column.
Actual result BEFORE applying this Pull Request
Attempting to change the published state of an item in a custom admin list view failed with error message, "Unknown column 'checked_out' in 'where clause'". The database column was properly aliased in the table's __construct() method with the following code:
$this->setColumnAlias('checked_out', 'checked_out_user_id');Expected result AFTER applying this Pull Request
Attempting to change the published state of an item in a custom admin list view succeeds.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed