[4.4] Language Filter strings#42687
Merged
MacJoom merged 3 commits intojoomla:4.4-devfrom Feb 6, 2024
Merged
Conversation
richard67
reviewed
Jan 21, 2024
administrator/components/com_finder/src/Helper/LanguageHelper.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Contributor
|
I have tested this item ✅ successfully on f0ee89d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42687. |
1 similar comment
|
I have tested this item ✅ successfully on f0ee89d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42687. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42687. |
Contributor
|
Thank you! |
Contributor
Author
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
With #36748
It is confusing that this doesnt work if debug is enabled. There is nothing else in Joomla where this is the case and I just wasted a lot of time trying to see why the string wasnt displayed.
I believe that the intention of the code was to display the language key when "debug language" was enabled not when "debug" was enabled
If you want to create your own value for the key as an override you would expect the key to be displayed in debug language mode (which it is not) and you would not expect the key to be displayed in debug mode
Testing Instructions
Perform a search on the front with Debug enabled and a new search with debug language enabled
Actual result BEFORE applying this Pull Request
Debug
Debug Language
Expected result AFTER applying this Pull Request
Debug
Debug Language
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed