Skip to content

[4.4] Language Filter strings#42687

Merged
MacJoom merged 3 commits intojoomla:4.4-devfrom
brianteeman:patch-5
Feb 6, 2024
Merged

[4.4] Language Filter strings#42687
MacJoom merged 3 commits intojoomla:4.4-devfrom
brianteeman:patch-5

Conversation

@brianteeman
Copy link
Contributor

Summary of Changes

With #36748

"This PR checks if a translation for the language key exists and if there is none (and debug is not enabled) it will instead display the taxonomy title instead."

It is confusing that this doesnt work if debug is enabled. There is nothing else in Joomla where this is the case and I just wasted a lot of time trying to see why the string wasnt displayed.

I believe that the intention of the code was to display the language key when "debug language" was enabled not when "debug" was enabled

If you want to create your own value for the key as an override you would expect the key to be displayed in debug language mode (which it is not) and you would not expect the key to be displayed in debug mode

Testing Instructions

Perform a search on the front with Debug enabled and a new search with debug language enabled

Actual result BEFORE applying this Pull Request

Debug

image

Debug Language

image

Expected result AFTER applying this Pull Request

Debug

image

Debug Language

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@richard67 richard67 added the bug label Jan 21, 2024
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
@Quy
Copy link
Contributor

Quy commented Feb 5, 2024

I have tested this item ✅ successfully on f0ee89d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42687.

1 similar comment
@ghost
Copy link

ghost commented Feb 6, 2024

I have tested this item ✅ successfully on f0ee89d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42687.

@Quy
Copy link
Contributor

Quy commented Feb 6, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42687.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 6, 2024
@MacJoom MacJoom self-assigned this Feb 6, 2024
@MacJoom MacJoom added this to the Joomla 4.4.3 milestone Feb 6, 2024
@MacJoom MacJoom merged commit bef1c83 into joomla:4.4-dev Feb 6, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 6, 2024
@MacJoom
Copy link
Contributor

MacJoom commented Feb 6, 2024

Thank you!

@brianteeman
Copy link
Contributor Author

thanks

@brianteeman brianteeman deleted the patch-5 branch February 6, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments