[4.4] Update phpseclib to 3.0.34#42470
Merged
MacJoom merged 2 commits intojoomla:4.4-devfrom Feb 19, 2024
Merged
Conversation
2 tasks
Member
Member
|
I have tested this item ✅ successfully on a518908 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42470. |
Contributor
|
Shouldn't we have also an update for composer.json, we have still "phpseclib/bcmath_compat": "^2.0.1" |
Contributor
Author
|
How is bcmath related to the PR @rdeutz ? |
Member
|
@SniperSister Meanwhile there is a new release 3.0.35 available. Changelog see https://github.com/phpseclib/phpseclib/releases/tag/3.0.35 . Would it make sense to update this PR to that release? |
Contributor
Author
|
@richard67 as we have updated to 3.0.34 in the 5.x branch I would suggest we do the same here. |
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Update phpseclib to 3.0.34 to fix https://nvd.nist.gov/vuln/detail/CVE-2023-49316.
Testing Instructions
Code review.