Skip to content

Comments

[5.1] Use Dialog for extensions changelog#42453

Merged
LadySolveig merged 12 commits intojoomla:5.1-devfrom
Fedik:popup-changelog
Jan 31, 2024
Merged

[5.1] Use Dialog for extensions changelog#42453
LadySolveig merged 12 commits intojoomla:5.1-devfrom
Fedik:popup-changelog

Conversation

@Fedik
Copy link
Member

@Fedik Fedik commented Dec 3, 2023

Summary of Changes

Use Dialog for extension changelog

Testing Instructions

You need an extension with changelog.
Open Extensions => Manage, find the extension with changelog and click changelog btn.
Open Update overview and click on the extension changelog btn, if there any update :)

Also can use Test instruction from #41675

Actual result BEFORE applying this Pull Request

Works with BS Modal

Expected result AFTER applying this Pull Request

Works with Joomla Dialog

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

References:

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev labels Dec 3, 2023
@Fedik Fedik added the Feature label Dec 3, 2023
@Quy
Copy link
Contributor

Quy commented Dec 10, 2023

I have tested this item ✅ successfully on 46f3b9c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42453.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 2b378a1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42453.

@alikon
Copy link
Contributor

alikon commented Dec 23, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42453.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 23, 2023
@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Jan 5, 2024
@LadySolveig LadySolveig merged commit 5f6581a into joomla:5.1-dev Jan 31, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 31, 2024
@LadySolveig
Copy link
Contributor

Thank you @Fedik and for testing @Quy @viocassel

@Fedik Fedik deleted the popup-changelog branch February 1, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants