Skip to content

Fix function parameter lost during redirect #42315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bembelimen merged 4 commits into from
Dec 31, 2023
Merged

Fix function parameter lost during redirect #42315

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7ccc2b9
Fix `function` parameter lost during redirect
janschoenherr Nov 7, 2023
231758d
Move function parameter to form url
janschoenherr Nov 20, 2023
41022b7
Remove hidden input
janschoenherr Nov 20, 2023
e48e3c1
Merge branch '5.0-dev' into patch-9
QuyTon Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions administrator/components/com_menus/tmpl/items/modal.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,14 @@
$editor = $app->getInput()->getCmd('editor', '');
$listOrder = $this->escape($this->state->get('list.ordering'));
$listDirn = $this->escape($this->state->get('list.direction'));
$link = 'index.php?option=com_menus&view=items&layout=modal&tmpl=component&' . Session::getFormToken() . '=1';
$link = 'index.php?option=com_menus&view=items&layout=modal&tmpl=component&' . Session::getFormToken() . '=1&function=' . $function;
$multilang = Multilanguage::isEnabled();

if (!empty($editor)) {
// This view is used also in com_menus. Load the xtd script only if the editor is set!
$this->document->addScriptOptions('xtd-menus', ['editor' => $editor]);
$onclick = "jSelectMenuItem";
$link = 'index.php?option=com_menus&view=items&layout=modal&tmpl=component&editor=' . $editor . '&' . Session::getFormToken() . '=1';
$link = 'index.php?option=com_menus&view=items&layout=modal&tmpl=component&editor=' . $editor . '&' . Session::getFormToken() . '=1&function=' . $function;
}
?>
<div class="container-popup">
Expand Down Expand Up @@ -186,7 +186,6 @@

<input type="hidden" name="task" value="">
<input type="hidden" name="boxchecked" value="0">
<input type="hidden" name="function" value="<?php echo $function; ?>">
<input type="hidden" name="forcedLanguage" value="<?php echo $app->getInput()->get('forcedLanguage', '', 'cmd'); ?>">
<?php echo HTMLHelper::_('form.token'); ?>

Expand Down