[5.0] Filter values of custom field, fix #42259

[Fedik]

Pull Request for Issue #42259 .

Summary of Changes

Filter field value after onCustomFieldsPrepareField

Testing Instructions

Please follow #42259
Create a Text field,
Save it,
And check the field rendering in the layout override.
Or use dump($this->item->jcfields); to see the field ->value

Actual result BEFORE applying this Pull Request

Value contain an empty space

Expected result AFTER applying this Pull Request

Value is empty

Link to documentations

Please select:

• Documentation link for docs.joomla.org:
• No documentation changes for docs.joomla.org needed
• Pull Request link for manual.joomla.org:
• No documentation changes for manual.joomla.org needed

Reference:

• [5.0][Events] Custom fields event classes #41495

[Scrabble96]

The com_patchtester_4.3.1 doesn't seem to work in J5 so I can't test this. The error message message says:

An error has occurred while fetching the data from GitHub.

Error inserting pull request data into the database: Incorrect string value: '\xF0\x9F\xA5\x87 )...' for column [mydomain]_joomlalatestversion.m2f0c_patchtester_pulls.description at row 13

[ghost]

No Problem using Patchtester 4.3.1 in J5.

[Scrabble96]

No Problem using Patchtester 4.3.1 in J5.

Can you confirm what needs to be checked/ticked when I get an access token? Is it just the default that the link from the Patchtester checks? I've installed it on a brand new installation of J5 on a brand new subdomain on a new database.

I uninstalled it, logged out, logged back in and installed it again. Same result.

[ghost]

[Scrabble96]

All those settings in Joomla are correct. What I meant was, what do I check/tick when I request an authentication token on Github at github.com/settings/tokens? I tried on another test site that had been updated from 4.4.0 to 5.0. Same result. It has public_repo, repo:status selected at the moment.

[ghost]

[angieradtke]

I have tested this item ✅ successfully on 4143e6b

Thanks Fedir, works as expected

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42285.}

[HLeithner]

@Scrabble96 can you please test this pr, simple use the prebuilt packages from https://artifacts.joomla.org/drone/joomla/joomla-cms/5.0-dev/42285/downloads/71682

[korenevskiy]

@Fedik And if you just return the value from the array when checking.

$value = array_filter($value, function ($v) {
  return $v;
});

or

$value = array_filter($value, fn ($v) => $v);

[Fedik]

@korenevskiy nope, what will hapen when value is '0'?

[korenevskiy]

@korenevskiy nope, what will hapen when value is '0'?

You right!

[Quy]

I have tested this item ✅ successfully on 4143e6b

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42285.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42285.}

[HLeithner]

thanks

[angieradtke]

Do we need this Fix in 4.4 as well?

[HLeithner]

No because we changed the plugin trigger code in 5.0 which leads to this issue.

[angieradtke]

ah ok - understand , thanks

[Scrabble96]

@Scrabble96 can you please test this pr, simple use the prebuilt packages from https://artifacts.joomla.org/drone/joomla/joomla-cms/5.0-dev/42285/downloads/71682

Hi @HLeithner - I've just got around to testing this. It works fine. Thank you all for fixing and testing this.

[Fedik]

@laoneo please check my previous comment #42285 (comment)
trim also a bad idea, it will remove "white space" value

[laoneo]

Thanks for the info

[Scrabble96]

Silly question, perhaps, but can whatever was done to change it from J4.4.0 to J.5.0 just be reversed, rather than adding yet more code?

[Fedik]

We have updated old events APi to new 😉