Skip to content

Comments

[5.0] Check if the value consist with id:alias, extract the id only#42096

Merged
bembelimen merged 1 commit intojoomla:5.0-devfrom
Fedik:fix42087
Oct 9, 2023
Merged

[5.0] Check if the value consist with id:alias, extract the id only#42096
bembelimen merged 1 commit intojoomla:5.0-devfrom
Fedik:fix42087

Conversation

@Fedik
Copy link
Member

@Fedik Fedik commented Oct 9, 2023

Pull Request for Issue #42087 .

Summary of Changes

The language association value stored as id:alias, however in j4 it was cast to int

that was not obvious change, but that affects evrything.
I have made it a bit more explicit in the afected fields

Testing Instructions

Please follow #42087

Actual result BEFORE applying this Pull Request

An error

Expected result AFTER applying this Pull Request

No error

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

Reference:

@alikon
Copy link
Contributor

alikon commented Oct 9, 2023

I have tested this item ✅ successfully on 45f33d2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42096.

1 similar comment
@chmst
Copy link
Contributor

chmst commented Oct 9, 2023

I have tested this item ✅ successfully on 45f33d2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42096.

@bembelimen bembelimen enabled auto-merge (squash) October 9, 2023 10:51
@bembelimen bembelimen disabled auto-merge October 9, 2023 10:52
@bembelimen bembelimen merged commit 431b0e7 into joomla:5.0-dev Oct 9, 2023
@bembelimen
Copy link
Contributor

Thank you for the PR and the tests.

@bembelimen bembelimen added this to the Joomla! 5.0.0 milestone Oct 9, 2023
@richard67
Copy link
Member

I just wanted to mark my successful test result, but you were faster :-)

I've tested the side-by-side views (associations) for menu items as well, and also for not associated articles and menu items, all that works.

What remains is the issue I have commented here #42087 (comment) , that the "Clear" button doesn't do anything in the associations side-by-side view. I will later created a new issue for that (if there is none yet).

@Fedik Fedik deleted the fix42087 branch October 9, 2023 10:57
@chmst
Copy link
Contributor

chmst commented Oct 9, 2023

grafik

Got this error for the Clear button

@Fedik
Copy link
Member Author

Fedik commented Oct 9, 2023

I made PR for Clear button #42098

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants