[5.0] Check if the value consist with id:alias, extract the id only#42096
Merged
bembelimen merged 1 commit intojoomla:5.0-devfrom Oct 9, 2023
Merged
[5.0] Check if the value consist with id:alias, extract the id only#42096bembelimen merged 1 commit intojoomla:5.0-devfrom
bembelimen merged 1 commit intojoomla:5.0-devfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on 45f33d2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42096. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 45f33d2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42096. |
Contributor
|
Thank you for the PR and the tests. |
Member
|
I just wanted to mark my successful test result, but you were faster :-) I've tested the side-by-side views (associations) for menu items as well, and also for not associated articles and menu items, all that works. What remains is the issue I have commented here #42087 (comment) , that the "Clear" button doesn't do anything in the associations side-by-side view. I will later created a new issue for that (if there is none yet). |
Contributor
Member
Author
|
I made PR for Clear button #42098 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pull Request for Issue #42087 .
Summary of Changes
The language association value stored as
id:alias, however in j4 it was cast tointjoomla-cms/administrator/components/com_content/src/Field/Modal/ArticleField.php
Line 61 in 1e7527b
I have made it a bit more explicit in the afected fields
Testing Instructions
Please follow #42087
Actual result BEFORE applying this Pull Request
An error
Expected result AFTER applying this Pull Request
No error
Link to documentations
Please select:
Reference: