[5.1] Deprecate app/db properties in ActionLogPlugin

[heelc29]

Summary of Changes

deprecate $app and $db property in ActionLogPlugin and their possible use replaced

I'm not sure about the horizon (J6.0 or J7.0) of the removal of the properties

Testing Instructions

check action logs are still working

Actual result BEFORE applying this Pull Request

deprecation messages are logged

joomla-cms/libraries/src/Plugin/CMSPlugin.php

Line 138 in bd79fd3

@trigger_error('The application should be injected through setApplication() and requested through getApplication().', E_USER_DEPRECATED);

joomla-cms/libraries/src/Plugin/CMSPlugin.php

Line 148 in bd79fd3

@trigger_error('The database should be injected through the DatabaseAwareInterface and trait.', E_USER_DEPRECATED);

Expected result AFTER applying this Pull Request

deprecation messages are still logged, but properties are no longer used and now themselves deprecated

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org: Add deprecation note for joomla/joomla-cms#42090 Manual#210

[laoneo]

If you do it in 5.0,then the removal must be 7.0.

[heelc29]

So the code to set the properties (in CMSPlugin) is not removed before 7.0?

[HLeithner]

So the code to set the properties (in CMSPlugin) is not removed before 7.0?

yes next+1 major version

[HLeithner]

also can you please create a deprecation entry in https://manual.joomla.org/migrations/50-51/new-deprecations

[heelc29]

also can you please create a deprecation entry in https://manual.joomla.org/migrations/50-51/new-deprecations

Done. joomla/Manual#210

[laoneo]

So the code to set the properties (in CMSPlugin) is not removed before 7.0?

If we will do that, then we still can copy the code to this class to support the properties till 7.0. But I doubt that we go to remove the code in CMSPlugin in 7.0.

[HLeithner]

@laoneo there is no reason to not merge this right?

[bembelimen]

I have tested this item ✅ successfully on 4fbb778

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42090.}

[laoneo]

I have tested this item ✅ successfully on 4fbb778

Tested with the action log plugin of DPCalendar.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42090.}

[LadySolveig]

Thank you @heelc29