[6.0] Remove template special color#42017
Conversation
|
Have tested this successfully. |
joomla-cms-bot
added
Language Change
|
@wilsonge deprecation is at least needed in the manual. is it critical to remove it in 5.0 or 5.x? |
build/media_source/templates/site/cassiopeia/scss/tools/variables/_variables.scss
Show resolved
Hide resolved
HLeithner
changed the title
HLeithner
changed the title
|
Tested this but it seems that this has already been resolved. For patch test |
|
This pull request has been automatically rebased to 5.2-dev. |
HLeithner
changed the title
|
@wilsonge could you update the PR to solve the conflicts? |
|
@wilsonge Any news about this one? |
|
I have solved ther conflicts this needs to be tested |
rdeutz
changed the title
|
Tested, btn-secondary resolved to same colour before and after patch. Special color gone from Atum options. No 'result selection' options in https://issues.joomla.org/tracker/joomla-cms/42017 |
|
|
||
| INSERT INTO `#__template_styles` (`id`, `template`, `client_id`, `home`, `title`, `inheritable`, `parent`, `params`) VALUES | ||
| (10, 'atum', 1, '1', 'Atum - Default', 1, '', '{"hue":"hsl(214, 63%, 20%)","bg-light":"#f0f4fb","text-dark":"#495057","text-light":"#ffffff","link-color":"#2a69b8","special-color":"#001b4c","colorScheme":"os","monochrome":"0","loginLogo":"","loginLogoAlt":"","logoBrandLarge":"","logoBrandLargeAlt":"","logoBrandSmall":"","logoBrandSmallAlt":""}'), | ||
| (10, 'atum', 1, '1', 'Atum - Default', 1, '', '{"hue":"hsl(214, 63%, 20%)","bg-light":"#f0f4fb","text-dark":"#495057","text-light":"#ffffff","link-color":"#2a69b8","monochrome":"0","loginLogo":"","loginLogoAlt":"","logoBrandLarge":"","logoBrandLargeAlt":"","logoBrandSmall":"","logoBrandSmallAlt":""}'), |
There was a problem hiding this comment.
Revert removing "colorScheme":"os"?
QuyTon
added
the
Updates Requested
|
@wilsonge Can you please have a look at this and see if it's still relevant |
12 participants
Summary of Changes
Removes the template special color from core. The only potential place this is used is in toolbar secondary buttons. As far as I can tell no core extensions actually use this. But there is a chance third parties do. We now revert back to using the default bootstrap secondary color in this case.
This is a b/c break if other people are using this CSS Var. However I can't see any obvious way for us to actually deprecate CSS variables.
Testing Instructions
Change the class of an existing button from btn-*** (success/error/action) etc. to btn-secondary.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed