[5.2] Remove call_user_func()#41988
Merged
Hackwar merged 3 commits intojoomla:5.2-devfrom Aug 25, 2024
Merged
Conversation
Member
|
This pull request has been automatically rebased to 5.1-dev. |
Member
|
This pull request has been automatically rebased to 5.2-dev. |
Contributor
|
I have tested this item ✅ successfully on 38bed88 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41988. |
Contributor
|
I have tested this item ✅ successfully on 38bed88 I tested the speed using microtime and hrtime hrtime $start = hrtime(true);
// the statement
$end = hrtime(true);
$eta = ($end-$start) / 1e+6;This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41988. |
Member
|
@pe7er For setting RTC it is not enough to just add the label on GitHub. It needs to change status in the issue tracker. I will do that now. P.S.: And changing just the branch label is also not right as it depends on the base branch, which is still 5.2-dev here. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41988. |
Member
|
Thank you for this contribution! 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Remove
call_user_func()in favour of direct call which is faster.Testing Instructions
Apply patch.
Actual result BEFORE applying this Pull Request
Slow
call_user_func()call on form field filter.Expected result AFTER applying this Pull Request
Fast call.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed