[5.0] Fix, trying to install "false" $package

[Fedik]

Pull Request for Issue #41907.

Summary of Changes

The installer should stop when package information was not found.

Testing Instructions

Please follow #41907

Actual result BEFORE applying this Pull Request

A PHP error, + Joomla error "Please enter a valid URL"

Expected result AFTER applying this Pull Request

No PHP error, only Joomla error "Please enter a valid URL"

Link to documentations

Please select:

• Documentation link for docs.joomla.org:
• No documentation changes for docs.joomla.org needed
• Pull Request link for manual.joomla.org:
• No documentation changes for manual.joomla.org needed

[wilsonge]

This feels weird. We are already trying to set defaults when package is null. How do we end up in a situation where it's false?

[Fedik]

One of following can easily create a false result

joomla-cms/administrator/components/com_installer/src/Model/InstallModel.php

Lines 385 to 399 in fa0800b

	// Did you give us a URL?
	if (!$url) {
	Factory::getApplication()->enqueueMessage(Text::_('COM_INSTALLER_MSG_INSTALL_ENTER_A_URL'), 'error');
	return false;
	}
	// We only allow http & https here
	$uri = new Uri($url);
	if (!in_array($uri->getScheme(), ['http', 'https'])) {
	Factory::getApplication()->enqueueMessage(Text::_('COM_INSTALLER_MSG_INSTALL_INVALID_URL_SCHEME'), 'error');
	return false;
	}

Similar applies to _getPackageFromFolder() and _getPackageFromUpload() methods.

[HLeithner]

thanks