Skip to content

[5.0] Update bootstrap to 5.3.2#41899

Merged
HLeithner merged 1 commit intojoomla:5.0-devfrom
HLeithner:5.0/depupdate/bootstrap
Sep 23, 2023
Merged

[5.0] Update bootstrap to 5.3.2#41899
HLeithner merged 1 commit intojoomla:5.0-devfrom
HLeithner:5.0/depupdate/bootstrap

Conversation

@HLeithner
Copy link
Member

Pin boostrap to 5.3.2 and cypress-joomla to 0.0.16 for now.

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.0-dev labels Sep 23, 2023
@HLeithner HLeithner enabled auto-merge (squash) September 23, 2023 18:33
@HLeithner HLeithner merged commit 76faffa into joomla:5.0-dev Sep 23, 2023
@HLeithner HLeithner deleted the 5.0/depupdate/bootstrap branch September 23, 2023 19:07
@laoneo
Copy link
Member

laoneo commented Sep 26, 2023

Why?

@HLeithner
Copy link
Member Author

Why? Why? The uomerge of bootstrap failed and I broke cypress-joomla 0.0.18

@laoneo
Copy link
Member

laoneo commented Sep 26, 2023

Why did the upmerge of bootstrap fail? If you pin it to the version we have also in 4.4 it looks like all is ok and no pin is needed. There must be a valid reason to pin to a fixed patch version and I do not see one for bootstrap.

@HLeithner
Copy link
Member Author

Don't know why the upmerge wasn't successful, should used ^3.5.2 for upgrade, will change this later.

This was referenced Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants