[5.0] Remove odd media manager border#41775
Merged
HLeithner merged 3 commits intojoomla:5.0-devfrom Sep 17, 2023
Merged
Conversation
joomla-cms-bot
added
NPM Resource Changed
Contributor
|
I have tested this item ✅ successfully on f6e6fe3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41775. |
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue raised by @Quy in #41409 .
Summary of Changes
Removes a very odd border in media manager that was basically invisible in light mode and in dark mode looked very weird but doesn't really solve a purpose. Also solves the color of the disk name (N.B. In light mode this color changes fractionally as I've moved the text to use the text color variable rather than the background color variable).
Testing Instructions
In media manager check the border is removed. Note if you look very carefully in light mode you can also see it extending out the shaded component area too. Check the colors of the disk name
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed