Skip to content

[5.0] Remove odd media manager border#41775

Merged
HLeithner merged 3 commits intojoomla:5.0-devfrom
wilsonge:fix/media-manager-border
Sep 17, 2023
Merged

[5.0] Remove odd media manager border#41775
HLeithner merged 3 commits intojoomla:5.0-devfrom
wilsonge:fix/media-manager-border

Conversation

@wilsonge
Copy link
Contributor

@wilsonge wilsonge commented Sep 17, 2023

Pull Request for Issue raised by @Quy in #41409 .

Summary of Changes

Removes a very odd border in media manager that was basically invisible in light mode and in dark mode looked very weird but doesn't really solve a purpose. Also solves the color of the disk name (N.B. In light mode this color changes fractionally as I've moved the text to use the text color variable rather than the background color variable).

Testing Instructions

In media manager check the border is removed. Note if you look very carefully in light mode you can also see it extending out the shaded component area too. Check the colors of the disk name

Actual result BEFORE applying this Pull Request

41409-media

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.0-dev labels Sep 17, 2023
@Quy
Copy link
Contributor

Quy commented Sep 17, 2023

I have tested this item ✅ successfully on f6e6fe3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41775.

@HLeithner HLeithner merged commit 8a79539 into joomla:5.0-dev Sep 17, 2023
@HLeithner
Copy link
Member

thanks

@wilsonge wilsonge deleted the fix/media-manager-border branch September 17, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants