[5.0] Fixes for calendar dark mode#41743
Merged
HLeithner merged 2 commits intojoomla:5.0-devfrom Sep 17, 2023
Merged
Conversation
joomla-cms-bot
added
NPM Resource Changed
wilsonge
force-pushed
the
fix/dark-mode-calendar
branch
from
88f56ab to
fe52293
Compare
Contributor
Author
|
I've decided to open this up for testing as it's at least an improvement on how it was. The SVG color can be fixed in a further PR. |
wilsonge
changed the title
Contributor
|
I have tested this item ✅ successfully on bdae4ca This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41743. |
Member
|
thanks, created new issue for the svg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue raised by @Quy in the dark mode PR #41409
Summary of Changes
Fixes interactions of the calendar in dark mode
Note: Currently the SVG Icon is not color'd correctly - I'm still trying to work on a fix for that will work for templates that don't support dark mode.
Testing Instructions
Check the calendar field in light and dark mode. Light mode shouldn't be any different but should be validated in both atum and cassiopia. Dark mode should look much more native!
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed