[4][webservice] user patch #41688
Merged
[4][webservice] user patch #41688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PATCH user alters password
|
I have tested this item ✅ successfully on bf01492 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41688. |
Member
|
Can you rebase this to 4.4 and add a system test? |
Contributor
Author
|
rebased to 4.4 |
Member
|
I don't like the mix of api tests with front end tests. Can this not be tested somehow differently if the password works? |
laoneo
added
the
Updates Requested
Contributor
Author
|
probably yes, but How ? |
Contributor
|
we would need to add an webservices rest api function to test the password |
wilsonge
approved these changes
Sep 26, 2023
Contributor
Just directly query the database. We don't really care about the raw password. Just the hash is unchanged before and after the webservice request. |
laoneo
removed
the
Updates Requested
Member
|
Thanks! |
HLeithner
pushed a commit
that referenced
this pull request
Sep 26, 2023
* Added api test for user field group (#41850) * Added api test for user field group (#41851) * system test com_config webservices (#41765) * system test com_config * id * divideandrollback * grr * rollback --------- Co-authored-by: Allon Moritz <[email protected]> * [4.3] WebauthnField missing translation (#41723) * redo of #41520 (#41856) * [4.4] add system tests for admin users (group/level) (#41910) * Use $document variable (#41917) * redirect (#41912) * Cypress test for com_privacy admin (#41834) * Cypress test for com_privacy admin * Update Consent.cy.js * [4.4] 500 error when 404 and debug on (#41893) * fix * missed new params * [4] Mismatched tag ids/tag names in articles webservice/api (#41397) * Mismatched tag ids/tag names in articles webservice/api * redone * new function * use the new helper function * cs --------- Co-authored-by: Martin Carl Kopp <[email protected]> * [4.4] Joomla Update Component check package when using Upload & Update (#41757) * Add checks of uploaded file to com_joomlaupdate * Use global namespace * Simplify language strings * Remove the major version check * Fix doc block of new method * Language string improvements - thanks Brian Co-authored-by: Brian Teeman <[email protected]> * Only check if zip PHP extension is loaded * Check manifest XML instead of Version.php * English improvements * Remove empty line from language file Co-authored-by: George Wilson <[email protected]> * Add alternative method if no zip PHP extension * Do it as elswehere * Remove unsupported compression method * Make sure file is opened as binary file * Remove special version suffix for pull request patched packages * Move version check to own method * Read chunks of max. 1MiB from central directory * Fix method name and calls * Fix code from tests with a CLI script * Add code comments * Small code simplification * Fix empy manifest XML file handling * Handle empty manifest file and start of file * Fix method description comment * Close file when throwing exceptions while open * Fix typo in code comment * Fix code comment. Co-authored-by: Quy <[email protected]> * Language string consistency --------- Co-authored-by: Brian Teeman <[email protected]> Co-authored-by: George Wilson <[email protected]> Co-authored-by: Allon Moritz <[email protected]> Co-authored-by: Quy <[email protected]> * Update template.es6.js (#41909) Optional chaining fix * Add build tool to check ruleset.xml for obsolete exclude patterns and optionally fix the file (#40278) * Add tool to check ruleset.xml for obsolete exclude patterns * Fix PHPCS * Add option to fix the XML file * Rename to check_ruleset_xml.php * Better help text for default value * Fix comment, too * [4][webservice] user patch (#41688) * [4] webservice com_user patch PATCH user alters password * system test --------- Co-authored-by: Allon Moritz <[email protected]> * Update tests/System/integration/administrator/components/com_users/Groups.cy.js Co-authored-by: heelc29 <[email protected]> * Update tests/System/integration/administrator/components/com_users/Levels.cy.js Co-authored-by: heelc29 <[email protected]> * Use maximebf/debugbar v1.19.0 (#41931) * Rebuild composer lock file * Explanation why we mix UI with API tests * Rebuild composer lock file because of webauth upgrade * Fix code style --------- Co-authored-by: rajputanuj31 <[email protected]> Co-authored-by: Nicola Galgano <[email protected]> Co-authored-by: heelc29 <[email protected]> Co-authored-by: Richard Fath <[email protected]> Co-authored-by: andyforrest <[email protected]> Co-authored-by: Denitz <[email protected]> Co-authored-by: Martin Carl Kopp <[email protected]> Co-authored-by: Brian Teeman <[email protected]> Co-authored-by: George Wilson <[email protected]> Co-authored-by: Quy <[email protected]> Co-authored-by: Olivier Buisard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #41681 .
Summary of Changes
fix PATCH user alters password
Testing Instructions
#41681
Actual result BEFORE applying this Pull Request
after PATCH unable to login for that user
Expected result AFTER applying this Pull Request
able to login