Merged
Conversation
joomla-cms-bot
added
the
NPM Resource Changed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for pr #40513.
Summary of Changes
Updates the version in the package.json file when the Joomla version is bumped. Additionally it uses 4 spaces for indentation, similar to the composer.json file.
Testing Instructions
On the command line in the Joomla root folder execute the following command:
php build/bump.php -v 5.0.0Actual result BEFORE applying this Pull Request
The version tag in the package.json file contains the old version 4.0.0.
Expected result AFTER applying this Pull Request
The version tag in the package.json file contains the old version 5.0.0.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed