Skip to content

5.0 Prefer is_object() vs gettype() #41670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HLeithner merged 1 commit into from
Sep 12, 2023
Merged

5.0 Prefer is_object() vs gettype() #41670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion administrator/components/com_actionlogs/src/Helper/ActionlogsHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public static function getCsvData($data): \Generator
sprintf(
'%s() requires an array or object implementing the Traversable interface, a %s was given.',
__METHOD__,
\gettype($data) === 'object' ? \get_class($data) : \gettype($data)
\is_object($data) ? \get_class($data) : \gettype($data)
)
);
}
Expand Down
2 changes: 1 addition & 1 deletion libraries/src/Document/Document.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -981,7 +981,7 @@ public function setModifiedDate($date)
'The $date parameter of %1$s must be a string or a %2$s instance, a %3$s was given.',
__METHOD__ . '()',
'Joomla\\CMS\\Date\\Date',
\gettype($date) === 'object' ? (\get_class($date) . ' instance') : \gettype($date)
\is_object($date) ? (\get_class($date) . ' instance') : \gettype($date)
)
);
}
Expand Down
4 changes: 2 additions & 2 deletions libraries/src/Feed/Feed.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public function __set($name, $value)
sprintf(
'%1$s "author" must be an instance of Joomla\\CMS\\Feed\\FeedPerson. %2$s given.',
\get_class($this),
\gettype($value) === 'object' ? \get_class($value) : \gettype($value)
\is_object($value) ? \get_class($value) : \gettype($value)
)
);
}
Expand Down Expand Up @@ -242,7 +242,7 @@ public function offsetSet($offset, $value): void
sprintf(
'%1$s entries must be an instance of Joomla\\CMS\\Feed\\FeedPerson. %2$s given.',
\get_class($this),
\gettype($value) === 'object' ? \get_class($value) : \gettype($value)
\is_object($value) ? \get_class($value) : \gettype($value)
)
);
}
Expand Down
4 changes: 2 additions & 2 deletions libraries/src/Feed/FeedEntry.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ public function __set($name, $value)
sprintf(
'%1$s "author" must be an instance of Joomla\\CMS\\Feed\\FeedPerson. %2$s given.',
\get_class($this),
\gettype($value) === 'object' ? \get_class($value) : \gettype($value)
\is_object($value) ? \get_class($value) : \gettype($value)
)
);
}
Expand All @@ -96,7 +96,7 @@ public function __set($name, $value)
sprintf(
'%1$s "source" must be an instance of Joomla\\CMS\\Feed\\Feed. %2$s given.',
\get_class($this),
\gettype($value) === 'object' ? \get_class($value) : \gettype($value)
\is_object($value) ? \get_class($value) : \gettype($value)
)
);
}
Expand Down