Skip to content

5.0 Objects are always passed by reference #41669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HLeithner merged 1 commit into from
Sep 12, 2023
Merged

5.0 Objects are always passed by reference #41669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions administrator/modules/mod_latest/src/Helper/LatestHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,12 @@ abstract class LatestHelper
/**
* Get a list of articles.
*
* @param Registry &$params The module parameters.
* @param ArticlesModel $model The model.
* @param Registry $params The module parameters.
* @param ArticlesModel $model The model.
*
* @return mixed An array of articles, or false on error.
*/
public static function getList(Registry &$params, ArticlesModel $model)
public static function getList(Registry $params, ArticlesModel $model)
{
$user = Factory::getUser();

Expand Down
6 changes: 3 additions & 3 deletions administrator/modules/mod_popular/src/Helper/PopularHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,14 @@ abstract class PopularHelper
/**
* Get a list of the most popular articles.
*
* @param Registry &$params The module parameters.
* @param ArticlesModel $model The model.
* @param Registry $params The module parameters.
* @param ArticlesModel $model The model.
*
* @return mixed An array of articles, or false on error.
*
* @throws \Exception
*/
public static function getList(Registry &$params, ArticlesModel $model)
public static function getList(Registry $params, ArticlesModel $model)
{
$user = Factory::getUser();

Expand Down
2 changes: 1 addition & 1 deletion libraries/src/Versioning/VersionableModelTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ trait VersionableModelTrait
*
* @since 4.0.0
*/
public function loadHistory($versionId, Table &$table)
public function loadHistory($versionId, Table $table)
{
// Only attempt to check the row in if it exists, otherwise do an early exit.
if (!$versionId) {
Expand Down